Skip to content

Conversation

@andrewgazelka
Copy link
Member

No description provided.

@github-actions github-actions bot added the chore label Feb 23, 2025
@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  23.4 ns ...  21.6 ns ]      -7.44%*
ray_intersection/aabb_size_1                       [  21.1 ns ...  19.1 ns ]      -9.51%*
ray_intersection/aabb_size_10                      [  21.1 ns ...  19.0 ns ]      -9.63%*
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.85%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      +0.58%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.93%
overlap/no_overlap                                 [  31.0 ns ...  28.5 ns ]      -7.97%*
overlap/partial_overlap                            [  31.1 ns ...  28.5 ns ]      -8.32%*
overlap/full_containment                           [  23.7 ns ...  21.6 ns ]      -8.56%*
point_containment/inside                           [   5.9 ns ...   4.9 ns ]     -16.69%
point_containment/outside                          [   5.3 ns ...   4.4 ns ]     -17.50%
point_containment/boundary                         [   5.9 ns ...   4.9 ns ]     -16.97%*

Comparing to e34af07

@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  21.2 ns ...  19.1 ns ]      -9.65%*
ray_intersection/aabb_size_1                       [  21.1 ns ...  19.0 ns ]      -9.66%*
ray_intersection/aabb_size_10                      [  21.2 ns ...  19.2 ns ]      -9.62%*
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.87%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      +1.25%
ray_intersection/ray_distance_20                   [   4.1 ns ...   4.1 ns ]      +0.67%
overlap/no_overlap                                 [  30.9 ns ...  28.9 ns ]      -6.32%*
overlap/partial_overlap                            [  31.9 ns ...  29.2 ns ]      -8.70%*
overlap/full_containment                           [  24.5 ns ...  21.9 ns ]     -10.37%*
point_containment/inside                           [   6.5 ns ...   5.4 ns ]     -16.30%*
point_containment/outside                          [   5.6 ns ...   4.6 ns ]     -17.31%
point_containment/boundary                         [   6.2 ns ...   5.2 ns ]     -16.02%

Comparing to e34af07

@codecov
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 21.07%. Comparing base (e34af07) to head (a1730e9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tools/packet-inspector/src/app/packet_list.rs 0.00% 7 Missing ⚠️
tools/rust-mc-bot/src/lib.rs 0.00% 3 Missing ⚠️
crates/hyperion/src/simulation/inventory.rs 0.00% 2 Missing ⚠️
tools/packet-inspector/src/tri_checkbox.rs 0.00% 2 Missing ⚠️
crates/hyperion-inventory/src/lib.rs 0.00% 1 Missing ⚠️
...rates/hyperion/src/simulation/blocks/loader/mod.rs 0.00% 1 Missing ⚠️
events/tag/src/main.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   22.96%   21.07%   -1.90%     
==========================================
  Files         159      159              
  Lines       16621    16625       +4     
  Branches      454      454              
==========================================
- Hits         3817     3503     -314     
- Misses      12711    13056     +345     
+ Partials       93       66      -27     
Files with missing lines Coverage Δ
crates/hyperion/src/lib.rs 85.06% <100.00%> (-0.13%) ⬇️
crates/hyperion/src/simulation/metadata/mod.rs 75.75% <ø> (ø)
crates/hyperion/src/simulation/mod.rs 37.58% <ø> (-1.35%) ⬇️
crates/hyperion-inventory/src/lib.rs 0.58% <0.00%> (ø)
...rates/hyperion/src/simulation/blocks/loader/mod.rs 3.81% <0.00%> (-9.75%) ⬇️
events/tag/src/main.rs 0.00% <0.00%> (ø)
crates/hyperion/src/simulation/inventory.rs 0.00% <0.00%> (ø)
tools/packet-inspector/src/tri_checkbox.rs 0.00% <0.00%> (ø)
tools/rust-mc-bot/src/lib.rs 0.00% <0.00%> (ø)
tools/packet-inspector/src/app/packet_list.rs 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  21.2 ns ...  19.2 ns ]      -9.36%*
ray_intersection/aabb_size_1                       [  21.3 ns ...  19.3 ns ]      -9.60%*
ray_intersection/aabb_size_10                      [  21.1 ns ...  19.1 ns ]      -9.66%*
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.76%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      +0.72%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.99%
overlap/no_overlap                                 [  31.0 ns ...  28.6 ns ]      -8.03%*
overlap/partial_overlap                            [  32.0 ns ...  29.0 ns ]      -9.34%*
overlap/full_containment                           [  24.5 ns ...  22.0 ns ]     -10.43%*
point_containment/inside                           [   6.0 ns ...   5.0 ns ]     -16.80%*
point_containment/outside                          [   5.9 ns ...   4.9 ns ]     -17.30%*
point_containment/boundary                         [   6.1 ns ...   5.1 ns ]     -16.05%

Comparing to e34af07

@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  21.1 ns ...  19.1 ns ]      -9.66%*
ray_intersection/aabb_size_1                       [  21.1 ns ...  19.0 ns ]      -9.69%*
ray_intersection/aabb_size_10                      [  21.1 ns ...  19.1 ns ]      -9.48%*
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.74%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      +0.86%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.92%
overlap/no_overlap                                 [  31.1 ns ...  28.7 ns ]      -7.52%*
overlap/partial_overlap                            [  30.2 ns ...  28.5 ns ]      -5.71%*
overlap/full_containment                           [  24.5 ns ...  21.6 ns ]     -11.76%*
point_containment/inside                           [   5.9 ns ...   4.9 ns ]     -16.82%
point_containment/outside                          [   5.3 ns ...   4.4 ns ]     -17.48%
point_containment/boundary                         [   5.9 ns ...   4.9 ns ]     -16.57%

Comparing to e34af07

@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  21.1 ns ...  19.0 ns ]     -10.01%*
ray_intersection/aabb_size_1                       [  21.2 ns ...  19.2 ns ]      -9.60%*
ray_intersection/aabb_size_10                      [  21.1 ns ...  19.0 ns ]      -9.79%*
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.79%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      +0.74%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.9 ns ]      +1.02%
overlap/no_overlap                                 [  31.2 ns ...  28.5 ns ]      -8.48%*
overlap/partial_overlap                            [  31.0 ns ...  28.6 ns ]      -7.81%*
overlap/full_containment                           [  23.5 ns ...  21.6 ns ]      -8.03%*
point_containment/inside                           [   5.9 ns ...   4.9 ns ]     -16.93%
point_containment/outside                          [   5.4 ns ...   4.4 ns ]     -17.46%
point_containment/boundary                         [   5.9 ns ...   5.0 ns ]     -16.32%

Comparing to e34af07

@andrewgazelka andrewgazelka added this pull request to the merge queue Feb 23, 2025
Merged via the queue into main with commit 84fbc78 Feb 23, 2025
9 checks passed
@andrewgazelka andrewgazelka deleted the andrew/update-deps2 branch February 23, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants