Skip to content

Conversation

@GroobleDierne
Copy link
Collaborator

No description provided.

@GroobleDierne GroobleDierne requested a review from Tebarem March 4, 2025 07:32
@github-actions github-actions bot added the fix label Mar 4, 2025
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  19.3 ns ...  19.3 ns ]      +0.09%
ray_intersection/aabb_size_1                       [  19.3 ns ...  19.3 ns ]      -0.11%
ray_intersection/aabb_size_10                      [  19.2 ns ...  19.3 ns ]      +0.36%
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.68%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      +0.25%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.18%
overlap/no_overlap                                 [  28.6 ns ...  28.6 ns ]      +0.17%
overlap/partial_overlap                            [  28.9 ns ...  28.9 ns ]      -0.03%
overlap/full_containment                           [  21.7 ns ...  21.6 ns ]      -0.28%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      -0.12%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      -0.31%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      +0.01%

Comparing to 473d35f

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 21.05%. Comparing base (473d35f) to head (79a6cfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/hyperion-inventory/src/lib.rs 0.00% 5 Missing ⚠️
@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   21.04%   21.05%           
=======================================
  Files         160      160           
  Lines       16870    16866    -4     
  Branches      471      470    -1     
=======================================
  Hits         3551     3551           
+ Misses      13253    13249    -4     
  Partials       66       66           
Files with missing lines Coverage Δ
crates/hyperion-inventory/src/lib.rs 0.58% <0.00%> (+<0.01%) ⬆️

Copy link
Collaborator

@Tebarem Tebarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GroobleDierne GroobleDierne added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 0419933 Mar 5, 2025
9 of 10 checks passed
@GroobleDierne GroobleDierne deleted the gui branch March 5, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants