Skip to content

Commit d3e77eb

Browse files
author
redpanther
committed
fix doxy
1 parent b49ada9 commit d3e77eb

File tree

5 files changed

+42
-13
lines changed

5 files changed

+42
-13
lines changed

include/blackborder/BlackBorderProcessor.h

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,18 @@ namespace hyperion
3434
///
3535
BlackBorder getCurrentBorder() const;
3636

37+
///
38+
/// Return activation state of black border detector
39+
/// @return The current border
40+
///
41+
bool enabled() const;
42+
43+
///
44+
/// Set activation state of black border detector
45+
/// @param enable current state
46+
///
47+
void setEnabled(bool enable);
48+
3749
///
3850
/// Processes the image. This performs detecion of black-border on the given image and
3951
/// updates the current border accordingly. If the current border is updated the method call
@@ -48,6 +60,11 @@ namespace hyperion
4860
{
4961
// get the border for the single image
5062
BlackBorder imageBorder;
63+
if (!enabled())
64+
{
65+
return false;
66+
}
67+
5168
if (_detectionMode == "default") {
5269
imageBorder = _detector.process(image);
5370
} else if (_detectionMode == "classic") {
@@ -69,7 +86,6 @@ namespace hyperion
6986
return borderUpdated;
7087
}
7188

72-
7389
private:
7490
///
7591
/// Updates the current border based on the newly detected border. Returns true if the
@@ -80,6 +96,9 @@ namespace hyperion
8096
///
8197
bool updateBorder(const BlackBorder & newDetectedBorder);
8298

99+
/// flag for blackborder detector usage
100+
bool _enabled;
101+
83102
/// The number of unknown-borders detected before it becomes the current border
84103
const unsigned _unknownSwitchCnt;
85104

include/hyperion/ImageProcessor.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class ImageProcessor
3939
void setSize(const unsigned width, const unsigned height);
4040

4141
/// Enable or disable the black border detector
42-
void enableBalckBorderDetector(bool enable);
42+
void enableBlackBorderDetector(bool enable);
4343

4444
///
4545
/// Processes the image to a list of led colors. This will update the size of the buffer-image
@@ -117,7 +117,7 @@ class ImageProcessor
117117
template <typename Pixel_T>
118118
void verifyBorder(const Image<Pixel_T> & image)
119119
{
120-
if(_enableBlackBorderRemoval && _borderProcessor->process(image))
120+
if(_borderProcessor->enabled() && _borderProcessor->process(image))
121121
{
122122
Debug(Logger::getInstance("BLACKBORDER"), "BORDER SWITCH REQUIRED!!");
123123

@@ -146,9 +146,6 @@ class ImageProcessor
146146
/// The Led-string specification
147147
const LedString _ledString;
148148

149-
/// Flag the enables(true)/disabled(false) blackborder detector
150-
bool _enableBlackBorderRemoval;
151-
152149
/// The processor for black border detection
153150
hyperion::BlackBorderProcessor * _borderProcessor;
154151

libsrc/blackborder/BlackBorderProcessor.cpp

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
using namespace hyperion;
1010

1111
BlackBorderProcessor::BlackBorderProcessor(const Json::Value &blackborderConfig)
12-
: _unknownSwitchCnt(blackborderConfig.get("unknownFrameCnt", 600).asUInt())
12+
: _enabled(blackborderConfig.get("enable", true).asBool())
13+
, _unknownSwitchCnt(blackborderConfig.get("unknownFrameCnt", 600).asUInt())
1314
, _borderSwitchCnt(blackborderConfig.get("borderFrameCnt", 50).asUInt())
1415
, _maxInconsistentCnt(blackborderConfig.get("maxInconsistentCnt", 10).asUInt())
1516
, _blurRemoveCnt(blackborderConfig.get("blurRemoveCnt", 1).asUInt())
@@ -20,14 +21,27 @@ BlackBorderProcessor::BlackBorderProcessor(const Json::Value &blackborderConfig)
2021
, _consistentCnt(0)
2122
, _inconsistentCnt(10)
2223
{
23-
Debug(Logger::getInstance("BLACKBORDER"), "mode: %s", _detectionMode.c_str());
24+
if (_enabled)
25+
{
26+
Debug(Logger::getInstance("BLACKBORDER"), "mode: %s", _detectionMode.c_str());
27+
}
2428
}
2529

2630
BlackBorder BlackBorderProcessor::getCurrentBorder() const
2731
{
2832
return _currentBorder;
2933
}
3034

35+
bool BlackBorderProcessor::enabled() const
36+
{
37+
return _enabled;
38+
}
39+
40+
void BlackBorderProcessor::setEnabled(bool enable)
41+
{
42+
_enabled = enable;
43+
}
44+
3145
bool BlackBorderProcessor::updateBorder(const BlackBorder & newDetectedBorder)
3246
{
3347
// the new changes ignore false small borders (no reset of consistance)
@@ -92,4 +106,4 @@ bool BlackBorderProcessor::updateBorder(const BlackBorder & newDetectedBorder)
92106
}
93107

94108
return borderChanged;
95-
}
109+
}

libsrc/effectengine/Effect.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Effect::Effect(PyThreadState * mainThreadState, int priority, int timeout, const
6666
_colors.resize(_imageProcessor->getLedCount(), ColorRgb::BLACK);
6767

6868
// disable the black border detector for effects
69-
_imageProcessor->enableBalckBorderDetector(false);
69+
_imageProcessor->enableBlackBorderDetector(false);
7070

7171
// connect the finished signal
7272
connect(this, SIGNAL(finished()), this, SLOT(effectFinished()));

libsrc/hyperion/ImageProcessor.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ using namespace hyperion;
1111
//ImageProcessor::ImageProcessor(const LedString& ledString, bool enableBlackBorderDetector, uint8_t blackborderThreshold) :
1212
ImageProcessor::ImageProcessor(const LedString& ledString, const Json::Value & blackborderConfig) :
1313
_ledString(ledString),
14-
_enableBlackBorderRemoval(blackborderConfig.get("enable", true).asBool()),
1514
_borderProcessor(new BlackBorderProcessor(blackborderConfig) ),
1615
_imageToLeds(nullptr)
1716
{
@@ -44,9 +43,9 @@ void ImageProcessor::setSize(const unsigned width, const unsigned height)
4443
_imageToLeds = new ImageToLedsMap(width, height, 0, 0, _ledString.leds());
4544
}
4645

47-
void ImageProcessor::enableBalckBorderDetector(bool enable)
46+
void ImageProcessor::enableBlackBorderDetector(bool enable)
4847
{
49-
_enableBlackBorderRemoval = enable;
48+
_borderProcessor->setEnabled(enable);
5049
}
5150

5251
bool ImageProcessor::getScanParameters(size_t led, double &hscanBegin, double &hscanEnd, double &vscanBegin, double &vscanEnd) const

0 commit comments

Comments
 (0)