Skip to content

Conversation

@Lord-Grey
Copy link
Collaborator

@Lord-Grey Lord-Grey commented Sep 24, 2025

Summary

⚠️ Breaking Changes

  • Align Hue Bridge processing to Philips' guidance on security, i.e. no self-signed certificates for orginal bridges

✨ Added

  • Hue Bridge - Use https and certificates for all API calls, support Bridge Pro (V3)
  • Hue Bridge - Alternate certificate support

🔧 Changed

  • Hue Bridge - Wizard updates to support bridge-ids, overall code refactoring
  • Corrected ssdp only linkages

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

  • No self-signed certificates for orginal bridges are supported. Update the bridges' firmware and restart the configuration wizzard

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

Fixes #1910

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements security enhancements for Philips Hue Bridge integration, aligning with Philips' guidance on HTTPS and certificate validation. The changes introduce support for Bridge Pro (V3) and enforce secure connections for official Hue bridges while maintaining compatibility with third-party bridges.

  • Enforce HTTPS with proper certificate validation for official Philips Hue bridges (no self-signed certificates)
  • Add Bridge-ID support throughout the configuration wizard and API interactions
  • Restructure CMake link dependencies to ensure proper linking order

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
libsrc/leddevice/dev_net/LedDevicePhilipsHue.cpp Core implementation of Hue bridge security enhancements and Bridge-ID handling
libsrc/leddevice/schemas/schema-philipshue.json Added bridgeid field and updated property ordering
assets/webconfig/js/wizards/LedDevice_philipshue.js Updated wizard to handle Bridge-ID discovery and configuration
resources/ssl/philips_hue_ca.pem Added new Hue Root CA certificate for Bridge Pro support
src/hyperion-*/CMakeLists.txt Moved hyperion-utils library linking to avoid dependency issues
libsrc/ssdp/CMakeLists.txt Added hyperion-utils dependency for SSDP functionality
assets/webconfig/i18n/en.json Added translation for Bridge-ID field
CHANGELOG.md Documented breaking changes and new features

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lord-Grey Lord-Grey merged commit eca1783 into hyperion-project:master Sep 27, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Output Devices Sep 27, 2025
@Lord-Grey Lord-Grey deleted the Hue branch September 27, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

philipshue wizard does not work with hue bridge pro

1 participant