-
-
Notifications
You must be signed in to change notification settings - Fork 406
Update Hue Bridge security #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements security enhancements for Philips Hue Bridge integration, aligning with Philips' guidance on HTTPS and certificate validation. The changes introduce support for Bridge Pro (V3) and enforce secure connections for official Hue bridges while maintaining compatibility with third-party bridges.
- Enforce HTTPS with proper certificate validation for official Philips Hue bridges (no self-signed certificates)
- Add Bridge-ID support throughout the configuration wizard and API interactions
- Restructure CMake link dependencies to ensure proper linking order
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libsrc/leddevice/dev_net/LedDevicePhilipsHue.cpp | Core implementation of Hue bridge security enhancements and Bridge-ID handling |
| libsrc/leddevice/schemas/schema-philipshue.json | Added bridgeid field and updated property ordering |
| assets/webconfig/js/wizards/LedDevice_philipshue.js | Updated wizard to handle Bridge-ID discovery and configuration |
| resources/ssl/philips_hue_ca.pem | Added new Hue Root CA certificate for Bridge Pro support |
| src/hyperion-*/CMakeLists.txt | Moved hyperion-utils library linking to avoid dependency issues |
| libsrc/ssdp/CMakeLists.txt | Added hyperion-utils dependency for SSDP functionality |
| assets/webconfig/i18n/en.json | Added translation for Bridge-ID field |
| CHANGELOG.md | Documented breaking changes and new features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
✨ Added
🔧 Changed
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)Fixes #1910
If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: