Skip to content

Conversation

@Portisch
Copy link
Contributor

@Portisch Portisch commented Feb 8, 2019

1. Tell us something about your changes.
With this change the flatc compiler will be found on amlogic
2. If this changes affect the .conf file. Please provide the changed section

3. Reference an issue (optional)

Note: For further discussions use our forum: forum.hyperion-project.org

@Portisch
Copy link
Contributor Author

Portisch commented Feb 8, 2019

Also here is a patch to add libarys to fix compiling for amlogic. But I am sure this will be device specific and can't be include with a pull request, isn't it?
https://gist.github.com/Portisch/1926ffab6b543d72792cf32da9e1cbb9

@Portisch Portisch closed this Feb 8, 2019
@Portisch Portisch deleted the fix_flatbuffer_library branch February 8, 2019 08:02
@Portisch Portisch restored the fix_flatbuffer_library branch February 8, 2019 08:03
@Portisch Portisch reopened this Feb 8, 2019
@RickDB
Copy link

RickDB commented Feb 8, 2019

Not sure if it's possible to make the CMAKE file selective for certain platforms as pretty sure it will break other platforms if we also include the extra-linking-libraries.patch.

@Portisch
Copy link
Contributor Author

Portisch commented Feb 8, 2019

I am also not sure. If it will not be accepted I add a local patch file.
BTW: it is no extra lib, it is just another way to search the flatc compiler.

I just tried the newest Hyperion version without any config change and it didn't work. So more testing is required.

@RickDB
Copy link

RickDB commented Feb 8, 2019

Want me to merge this one already and optionally that patch in a separate PR later?

@Portisch
Copy link
Contributor Author

Portisch commented Feb 8, 2019

Without this patch it won't compile on Coreelec anyway.

@RickDB
Copy link

RickDB commented Feb 8, 2019

Gonna ping @Paulchen-Panther then to check if there's way to include this patch.

@RickDB RickDB mentioned this pull request Feb 8, 2019
@RickDB
Copy link

RickDB commented Feb 8, 2019

What you could do in the meantime is include the patch in this PR, Travis will let's know if it compiles properly and can do local testing afterwards as an additional check.

@Paulchen-Panther
Copy link
Member

Also here is a patch to add libarys to fix compiling for amlogic. But I am sure this will be device specific and can't be include with a pull request, isn't it?
https://gist.github.com/Portisch/1926ffab6b543d72792cf32da9e1cbb9

Yes, it's possible

if (ENABLE_AMLOGIC)
target_link_libraries(${PROJECT_NAME} pcre16 dl z)
endif ()

@Portisch
Copy link
Contributor Author

I have done a new "compile fix" PR: #536

@Portisch Portisch closed this Feb 12, 2019
@Portisch Portisch deleted the fix_flatbuffer_library branch March 27, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants