-
-
Notifications
You must be signed in to change notification settings - Fork 406
fix amlogic flatbuffer library #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also here is a patch to add libarys to fix compiling for amlogic. But I am sure this will be device specific and can't be include with a pull request, isn't it? |
|
Not sure if it's possible to make the CMAKE file selective for certain platforms as pretty sure it will break other platforms if we also include the extra-linking-libraries.patch. |
|
I am also not sure. If it will not be accepted I add a local patch file. I just tried the newest Hyperion version without any config change and it didn't work. So more testing is required. |
|
Want me to merge this one already and optionally that patch in a separate PR later? |
|
Without this patch it won't compile on Coreelec anyway. |
|
Gonna ping @Paulchen-Panther then to check if there's way to include this patch. |
|
What you could do in the meantime is include the patch in this PR, Travis will let's know if it compiles properly and can do local testing afterwards as an additional check. |
Yes, it's possible |
|
I have done a new "compile fix" PR: #536 |
1. Tell us something about your changes.
With this change the flatc compiler will be found on amlogic
2. If this changes affect the .conf file. Please provide the changed section
3. Reference an issue (optional)
Note: For further discussions use our forum: forum.hyperion-project.org