fix(header): export tm! macro
#515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is used in the `header!` macro, which is exported as well. If `tm!` is not exported, external clients cannot user otherwise exported macros anymore who are dependent on `tm!`.
Contributor
|
Probably this should have a better name if it is exported. |
Contributor
Author
|
Indeed, I just did a 'I need this real quick' PR and ignored the fact that I have no clue what it does. |
Member
|
I'm thinking along the lines of what I did for the mime! macro, until rust-lang/rust#25003 is fixed. |
Member
|
See #523 |
Contributor
Author
|
Thanks. The fix works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used in the
header!macro, which is exported as well.If
tm!is not exported, external clients cannot user otherwiseexported macros anymore who are dependent on
tm!.