Skip to content

Conversation

@winding-lines
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 89.27% when pulling 59d8e80 on winding-lines:coverage into 9dc8527 on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 89.27% when pulling b24e1a5 on winding-lines:coverage into 9dc8527 on hyperium:master.

@winding-lines
Copy link
Contributor Author

hm, this PR is not very successful in increasing coverage, I may just drop it.

@seanmonstar
Copy link
Member

I'll merge this, since it also tests the cause() part, which is a good idea. If there was a way to pass to kcov to ignore all fns inside a #[cfg(test)] mod, that would greatly help reduce inflated "lines missed" values.

seanmonstar added a commit that referenced this pull request May 28, 2015
test(error): increasing test coverage of error module
@seanmonstar seanmonstar merged commit 1e5d7d4 into hyperium:master May 28, 2015
@winding-lines
Copy link
Contributor Author

Great :)

Marius

On May 28, 2015, at 10:39 AM, Sean McArthur notifications@github.com wrote:

I'll merge this, since it also tests the cause() part, which is a good idea. If there was a way to pass to kcov to ignore all fns inside a #[cfg(test)] mod, that would greatly help reduce inflated "lines missed" values.


Reply to this email directly or view it on GitHub.

@winding-lines winding-lines deleted the coverage branch May 29, 2015 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants