set up test framework for client, server and the travis #59

fenglianxu · 2018-01-25T17:50:01Z

set up auto-test framework for client, server and travis #58
Signed-off-by: xufengli xufengli@uk.ibm.com

Signed-off-by: xufengli <xufengli@uk.ibm.com>

nklincoln · 2018-01-26T15:40:59Z

client/test/data/test.cto

@@ -0,0 +1,41 @@
+/*


I'd recommend using a deeper test folder structure here to help you out further down the line:
data/valid
data/valid/cto
data/valid/acl
data/valid/project

data/invalid

etc, etc

Otherwise once you build up a large number of resources, it will be unmaintainable

I will add these as needed per our chat.

move the files to data/valid/cto and data/valid/acl now and will update others as needed.

nklincoln · 2018-01-26T15:42:21Z

client/test/extension.test.ts

-		assert.equal(-1, [1, 2, 3].indexOf(0));
+
+	// test validation cto
+	test("activate", () => {


we're not actually testing activate here, we're testing the ability to open a file using the vscode api

nklincoln · 2018-01-26T15:42:31Z

client/test/extension.test.ts

+            return Promise.reject(err);
+		});
+
+		// let serverOptions: ServerOptions = {


Need to remove comments!

nklincoln · 2018-01-26T15:42:52Z

client/test/extension.test.ts

+		// let serverOptions: ServerOptions = {
+		// 	run: { module: serverModule, transport: TransportKind.ipc }
+		// }
+		console.log('is activate called?');


Need to remove console logging

nklincoln · 2018-01-26T15:43:29Z

client/test/extension.test.ts

+		workspace.openTextDocument(uri).then((document) =>{
+
+			let text = document.getText();
+			console.log('text = ' + text);


should not have console logging in the test output, as this will clutter the test file output

nklincoln · 2018-01-26T15:47:15Z

server/test/server.spec.ts

+// The module 'assert' provides assertion methods from node
+import * as assert from 'assert';
+
+// You can import and use all API from the 'vscode' module


Probably don't want this generic template text either

@nklincoln I have updated files per your comments. can you review it again please?

nklincoln · 2018-01-26T15:47:54Z

server/test/server.spec.ts

+	it("validateCtoModelFile", () => {
+
+		let originatingFileName: string = "./test/data/test.cto";
+		console.log('is server called?');


no console logging in delivered test code as it clutters the logs - use asserts

nklincoln · 2018-01-26T15:51:28Z

server/test/server.spec.ts

+
+
+	// test validation cto
+	it("validateCtoModelFile", () => {


All mocha tests should follow a specific format if using a 'describe' framework, as shown here: https://mochajs.org/

This is so that the actual test intention is clear to a third party

nklincoln · 2018-01-26T15:51:47Z

server/test/server.spec.ts

+
+		let originatingFileName: string = "./test/data/test.cto";
+		console.log('is server called?');
+		// server.validateCtoModelFile( originatingFileName);


should this be commented out?

nklincoln · 2018-01-26T15:57:18Z

server/package.json

+  "nyc": {
+    "exclude": [
+      "coverage/**",
+      "out/**",


these don't exist in the vscode repository ... why are they here?

nklincoln

some minor changes required, but looks good 👍

nklincoln · 2018-01-31T11:40:45Z

server/src/server.ts

-  //Note: if the command is launched from the keyboard shortcut or the command palette,
-  //we will not have any arguments passed in so cannot get the filename to use in the diagram.
+  // create a title from the event info
+  let diagramTitle = 'Business Network Definition'; // ensible default


's' missing in sensible

all updated now

nklincoln · 2018-01-31T11:51:08Z

client/test/extension.test.ts

+
+    }, (err) => {
+      assert.ok(false, `error in OpenTextDocument ${err}`);
+      return Promise.reject(err);


this line is redundant as it will fail the test based on the assert above it

nklincoln · 2018-01-31T11:51:42Z

client/test/extension.test.ts

+
+    }, (err) => {
+      assert.ok(false, `error in OpenTextDocument ${err}`);
+      return Promise.reject(err);


don't need this here as the assert above will fail the test

nklincoln · 2018-01-31T11:52:39Z

client/test/extension.test.ts

+
+    workspace.openTextDocument(uri).then((err) => {
+      assert.ok(false, `error in OpenTextDocument ${err}`);
+      return Promise.reject(err);


Update the client json script Add Apach 2 copyright to the test files Add one invalid test file Add tslint to check all *.ts format. update minor changes. remove the failued test case. Signed-off-by: xufengli <xufengli@uk.ibm.com>

set up test framework for client, server and the travis

3d4190e

Signed-off-by: xufengli <xufengli@uk.ibm.com>

fenglianxu force-pushed the test-58 branch from d7b4834 to fd4ee3f Compare January 25, 2018 19:56

fenglianxu requested a review from nklincoln January 25, 2018 20:12

fenglianxu force-pushed the test-58 branch 8 times, most recently from 84cf963 to 393696d Compare January 26, 2018 15:03

nklincoln suggested changes Jan 26, 2018

View reviewed changes

fenglianxu force-pushed the test-58 branch 2 times, most recently from 1bf0046 to 9875d77 Compare January 28, 2018 17:02

fenglianxu self-assigned this Jan 28, 2018

fenglianxu force-pushed the test-58 branch 5 times, most recently from c76e979 to eb9de93 Compare January 29, 2018 15:29

nklincoln previously approved these changes Jan 29, 2018

View reviewed changes

fenglianxu dismissed nklincoln’s stale review via 23e03a7 January 30, 2018 21:52

fenglianxu force-pushed the test-58 branch from 70d0f9d to 23e03a7 Compare January 30, 2018 21:52

nklincoln suggested changes Jan 31, 2018

View reviewed changes

fenglianxu force-pushed the test-58 branch from f311133 to 007a678 Compare January 31, 2018 12:06

Change the code coverage report to be 0 for at moment.

9ff676e

Update the client json script Add Apach 2 copyright to the test files Add one invalid test file Add tslint to check all *.ts format. update minor changes. remove the failued test case. Signed-off-by: xufengli <xufengli@uk.ibm.com>

fenglianxu force-pushed the test-58 branch from 64e0e75 to 9ff676e Compare January 31, 2018 13:10

Merge branch 'master' into test-58

e6f2c6c

nklincoln approved these changes Jan 31, 2018

View reviewed changes

fenglianxu merged commit 89f7095 into hyperledger-archives:master Jan 31, 2018

set up test framework for client, server and the travis #59

set up test framework for client, server and the travis #59

Uh oh!

Conversation

fenglianxu commented Jan 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nklincoln left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants