This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Tidy up subscriptions to event emitters on navigation away from page #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1091
Previous behaviour was to create a new subscription to the same event upon return to page - this was resulting in actioning all subscriber callbacks when an event was emitted. This was resulting in both a memory leak, and the code being executed on out of date information.
Steps to Reproduce
Detailed within #1091
Design of the fix
Cleanup within an ngOnDestroy, that switches a flag used by a "takeWhile" applied to the subscription
Validation of the fix
Application of best practise clean-up for angular subscribers. Manual testing completed against original scenario, in addition to exploratory testing.
Automated Tests
Updated existing unit tests.