Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Conversation

@mbwhite
Copy link
Contributor

@mbwhite mbwhite commented Jun 20, 2017

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

@mbwhite mbwhite requested a review from sstone1 June 20, 2017 08:46
@mbwhite mbwhite merged commit 8931b3b into hyperledger-archives:master Jun 20, 2017
@mbwhite mbwhite deleted the defect-1334 branch June 20, 2017 09:26
mbwhite added a commit that referenced this pull request Jun 20, 2017
* Minor version bump due required due to system models

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Work in progress

!!! DO NOT MERGE !!!

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* merges

* updates

* first pass

* Add Various Tests (#1311)

Added tests to add-connection-profile
Updated tests for connection-profile
Updated tests for connection-profile-data
Updated tests for basic models

* Grammar, parser and model for queries (#1305)

* Fixed broken links in docs

* Workin in progress changes for query DSL

* wip

* wip

* unit testing

* fixes to the decorate

* fix tests

* model fixes

* add auto scroll to selected item in list (#1307)

* Refactor and code tidy as part of #796 (#1296)

* 409: Use ValueGenerator strategy for generating resource values

* Use proper case for Data heading on Test page (#496)

* Change generate option to a string on composer-common.Factory functions

* Change sed command for better compatibility (#1)

Use the -i option instead of --in-place as this is a synonym but has better support across different versions of sed; in particular the default sed on MacOS only provides -i and not --in-place.

* Fix path name in weekly QA doc

* Refactor of Factory to remove duplicate code

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Correct changelog.txt

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Correct some logic errors getting class declarations

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Increase unit test coverage

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Message and unit test improvements.

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Fix BusinessNetworkConnector tests for changes to error message text

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* drop in the detection script for live testing (#1286)

* drop in the detection script for live testing

* correct range variable

* updates

* remove rm from the insatgller (#1310)

* Expose the select statement for a query (#1333)

* Defect 1334 (#1335)

* make sure the docker images are pulled at the correct version

* remove unrequired unstable yml file

* Feature docs only (#1336)

* drop in the detection script for live testing

* correct range variable

* updates

* correct failing script

* retrofitting unit tests
mbwhite added a commit that referenced this pull request Jun 20, 2017
* Minor version bump due required due to system models

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* Work in progress

!!! DO NOT MERGE !!!

Signed-off-by: James Taylor <jamest@uk.ibm.com>

* merges

* updates

* first pass

* Add Various Tests (#1311)

Added tests to add-connection-profile
Updated tests for connection-profile
Updated tests for connection-profile-data
Updated tests for basic models

* Grammar, parser and model for queries (#1305)

* Fixed broken links in docs

* Workin in progress changes for query DSL

* wip

* wip

* unit testing

* fixes to the decorate

* fix tests

* model fixes

* add auto scroll to selected item in list (#1307)

* Refactor and code tidy as part of #796 (#1296)

* 409: Use ValueGenerator strategy for generating resource values

* Use proper case for Data heading on Test page (#496)

* Change generate option to a string on composer-common.Factory functions

* Change sed command for better compatibility (#1)

Use the -i option instead of --in-place as this is a synonym but has better support across different versions of sed; in particular the default sed on MacOS only provides -i and not --in-place.

* Fix path name in weekly QA doc

* Refactor of Factory to remove duplicate code

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Correct changelog.txt

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Correct some logic errors getting class declarations

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Increase unit test coverage

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Message and unit test improvements.

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* Fix BusinessNetworkConnector tests for changes to error message text

Signed-off-by: Mark S. Lewis <Mark_Lewis@uk.ibm.com>

* drop in the detection script for live testing (#1286)

* drop in the detection script for live testing

* correct range variable

* updates

* remove rm from the insatgller (#1310)

* Expose the select statement for a query (#1333)

* Defect 1334 (#1335)

* make sure the docker images are pulled at the correct version

* remove unrequired unstable yml file

* Feature docs only (#1336)

* drop in the detection script for live testing

* correct range variable

* updates

* correct failing script

* retrofitting unit tests

* more unit test retrofitting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants