feat(castor)!: http did resolver #221
Merged
+824
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goncalo-frade-iohk
force-pushed
the
feature/did-resolver-http
branch
2 times, most recently
from
87fae95 to
0b1e503
Compare
6 tasks
yshyn-iohk
reviewed
Oct 9, 2025
EdgeAgentSDK/Castor/Sources/Resolvers/GitHubPrismDIDResolver.swift
Outdated
Show resolved
Hide resolved
goncalo-frade-iohk
force-pushed
the
feature/did-resolver-http
branch
from
0b1e503 to
3efdb09
Compare
This is quite extensive PR since it makes the DIDDocument codable. Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
goncalo-frade-iohk
force-pushed
the
feature/did-resolver-http
branch
from
3efdb09 to
3fec8b3
Compare
FabioPinheiro
approved these changes
Oct 30, 2025
FabioPinheiro
left a comment
FabioPinheiro
left a comment
There was a problem hiding this comment.
For my little understanding looks good
|
|
||
| public func resolve(did: Domain.DID) async throws -> Domain.DIDDocument { | ||
| do { | ||
| return try await shortFormResolver.resolve(did: did) |
There was a problem hiding this comment.
Does this try to resolve the short form. Independently if the given DID is a long or a short form, right?
Contributor
Author
There was a problem hiding this comment.
Yes this is dependent on the dependency injection, but our short form resolver is here EdgeAgentSDK/Castor/Sources/Resolvers/EndpointShortFormPrismDIDRemoteResolver.swift, and is as you say it will work for short and long form independently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is quite extensive PR since it makes the DIDDocument codable.
Alternatives Considered (optional):
Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.
Checklist: