fix: update signature encoding to follow JWS specification #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The signed presentation for the credential request is DER-encoded, according to the JWS specification, the signature should not be DER-encoded. Instead, it should be a concatenation of R || S, Base64 URL-safe encoded (as per RFC 7515, Section 8.1)
(hyperledger-identus/cloud-agent#1541)
Alternatives Considered (optional):
Yes not follow the JWS and fix in cloud-agent to support both DER Encoded and JWS but will require handling both and wont benefit much, since it is JWT we should follow JWS spec
Checklist: