-
Notifications
You must be signed in to change notification settings - Fork 239
MinBFT #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinBFT #32
Conversation
Signed-off-by: Yuta Namiki <y-namiki@ak.jp.nec.com>
|
It would be nice to make the github ids of the initial contributors actually links to the corresponding pages for convenience and add the email address or github id of the sponsor. Just to make it easier for people to see who's being this. But otherwise, I think this is a perfect fit for the labs. So, +1 for me! |
|
Echo Arnaud's comments. So once that is fixed +1 from me as well. |
|
Same here, +1 |
|
Thanks for your review. I will update the proposal later. |
|
Great! Once the proposal has been updated, it looks like we can go forward with creating a lab. I will be on the watch for an update. |
- Initial Committers: Use links - Sponsor: Add an e-mail address Signed-off-by: Yuta Namiki <y-namiki@ak.jp.nec.com>
|
I have updated the proposal to include the links for the initial contributors and the email address of the sponsor. |
|
Created https://github.com/hyperledger-labs/minbft. Bringing over an existing repository is only possible if every commit in your existing repo is signed-off so there are no DCO related issues. Since that was not the case, you will need to bring your code over to the repository by squashing all of your commits into a single first commit made against your new lab repo with your sign-off. |
|
Thanks, we plan to bring over our existing repository. I have confirmed that every commits excluding merge commits in the repo is signed-off at hyperledger-labs/minbft@91aba02. |
New Proposal: MinBFT.