Skip to content

Conversation

@ynamiki
Copy link

@ynamiki ynamiki commented Jul 26, 2018

New Proposal: MinBFT.

Signed-off-by: Yuta Namiki <y-namiki@ak.jp.nec.com>
@lehors
Copy link
Contributor

lehors commented Jul 27, 2018

It would be nice to make the github ids of the initial contributors actually links to the corresponding pages for convenience and add the email address or github id of the sponsor. Just to make it easier for people to see who's being this. But otherwise, I think this is a perfect fit for the labs. So, +1 for me!

@vipinsun
Copy link
Contributor

Echo Arnaud's comments. So once that is fixed +1 from me as well.

@trbs
Copy link
Contributor

trbs commented Jul 28, 2018

Same here, +1

@ynamiki
Copy link
Author

ynamiki commented Jul 31, 2018

Thanks for your review. I will update the proposal later.

@tkuhrt
Copy link
Contributor

tkuhrt commented Jul 31, 2018

Great! Once the proposal has been updated, it looks like we can go forward with creating a lab. I will be on the watch for an update.

- Initial Committers: Use links
- Sponsor: Add an e-mail address

Signed-off-by: Yuta Namiki <y-namiki@ak.jp.nec.com>
@ynamiki
Copy link
Author

ynamiki commented Jul 31, 2018

I have updated the proposal to include the links for the initial contributors and the email address of the sponsor.

@tkuhrt
Copy link
Contributor

tkuhrt commented Jul 31, 2018

Created https://github.com/hyperledger-labs/minbft. Bringing over an existing repository is only possible if every commit in your existing repo is signed-off so there are no DCO related issues. Since that was not the case, you will need to bring your code over to the repository by squashing all of your commits into a single first commit made against your new lab repo with your sign-off.

@tkuhrt tkuhrt merged commit c9f723f into LF-Decentralized-Trust-labs:master Jul 31, 2018
@ynamiki ynamiki deleted the minbft branch July 31, 2018 23:29
@ynamiki
Copy link
Author

ynamiki commented Aug 2, 2018

Thanks, we plan to bring over our existing repository. I have confirmed that every commits excluding merge commits in the repo is signed-off at hyperledger-labs/minbft@91aba02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants