Skip to content

Conversation

@moritzkiefer-da
Copy link
Contributor

fixes #1170

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@moritzkiefer-da moritzkiefer-da requested a review from nicu-da June 19, 2025 07:08
[ci]

fixes #1170

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/overwrite-bootstrap branch from e0260d6 to 8856c07 Compare June 19, 2025 07:09
@moritzkiefer-da
Copy link
Contributor Author

@nicu-da I did test this manually, do you have a great idea for an automatic test? We could set it in one of our deployments but that doesn't actually test anything unless the deployment breaks if the bootstrap script doesn't run and that goes against our whole idea of not really relying on bootstrap scripts. Also happy to merge it without a test if you agree.

Copy link
Contributor

@nicu-da nicu-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's simple enough that merging without testing should do the trick.
We could add a simple test that checks that the file is written correctly in a deployment in a pod/container directly

@moritzkiefer-da moritzkiefer-da enabled auto-merge (squash) June 19, 2025 07:18
@moritzkiefer-da
Copy link
Contributor Author

I think it's simple enough that merging without testing should do the trick.

going without a test for now then, thanks for the input

@moritzkiefer-da moritzkiefer-da merged commit 1e59217 into main Jun 19, 2025
60 checks passed
@moritzkiefer-da moritzkiefer-da deleted the cocreature/overwrite-bootstrap branch June 19, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support easily running custom bootstrap scripts

4 participants