Skip to content

Conversation

@nicu-da
Copy link
Contributor

@nicu-da nicu-da commented Jun 23, 2025

part of #689

should improve handling of updates by the workspace during resets

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
@nicu-da nicu-da force-pushed the nicuda/pulumi/increase_termination branch from c55143e to 64027c6 Compare June 23, 2025 08:31
@nicu-da nicu-da requested a review from Copilot June 23, 2025 08:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the operator termination and workspace deletion grace period settings by replacing hard-coded numeric values with a shared constant, PulumiOperatorGracePeriod, to support future updates and improve consistency.

  • Replaces direct 1800-second values in operator and stack configuration with PulumiOperatorGracePeriod.
  • Updates expected JSON outputs accordingly, ensuring consistency across workspace and deployment configurations.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cluster/pulumi/operator/src/operator.ts Replaces literal terminationGracePeriodSeconds value with PulumiOperatorGracePeriod for the operator release.
cluster/pulumi/common/src/operator/stack.ts Introduces PulumiOperatorGracePeriod for both deletionGracePeriodSeconds and terminationGracePeriodSeconds in the stack manifest.
cluster/pulumi/common/src/operator/config.ts Defines the PulumiOperatorGracePeriod constant, centralizing the grace period configuration.
cluster/expected/operator/expected.json Updates expected values for deletion and termination grace periods.
cluster/expected/deployment/expected.json Updates expected values for deletion and termination grace periods in deployments.
Comments suppressed due to low confidence (2)

cluster/pulumi/common/src/operator/config.ts:22

  • Consider adding an inline comment explaining the purpose of PulumiOperatorGracePeriod and the rationale behind the 1800-second value to aid future maintainers.
export const PulumiOperatorGracePeriod = 1800;

cluster/pulumi/common/src/operator/stack.ts:363

  • Verify that using the same PulumiOperatorGracePeriod for both deletionGracePeriodSeconds and terminationGracePeriodSeconds aligns with the intended behavior and document any differences between these settings if necessary.
              deletionGracePeriodSeconds: PulumiOperatorGracePeriod,

@nicu-da nicu-da requested a review from moritzkiefer-da June 23, 2025 08:45
@nicu-da nicu-da merged commit 5cb8121 into main Jun 23, 2025
41 checks passed
@nicu-da nicu-da deleted the nicuda/pulumi/increase_termination branch June 23, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants