Skip to content

Conversation

@martinflorian-da
Copy link
Contributor

Otherwise it seems like we're added back as assignees whenever a PR is edited.

I prefer to unassign myself from PRs that are already shepherded by someone, so they stop showing up in my gh status and other overviews.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Otherwise it seems like we're added back as assignees whenever a PR is edited.

I prefer to unassign myself from PRs that are already shepherded by someone, so they stop showing up in my `gh status` and other overviews.

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like the behavior where you're assigned to everything but this probably makes more sense

@martinflorian-da
Copy link
Contributor Author

FYI @isegall-da @ray-roestenburg-da

@martinflorian-da martinflorian-da marked this pull request as ready for review July 2, 2025 09:57
@martinflorian-da martinflorian-da enabled auto-merge (squash) July 2, 2025 09:58
@martinflorian-da martinflorian-da merged commit ca9c26c into main Jul 2, 2025
42 checks passed
@martinflorian-da martinflorian-da deleted the martinflorian-da/fix-pr-reassign branch July 2, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants