Add config rendering helper function and enhance splice-participant helm template

[timpel-fcs]

Pull Request Checklist

Cluster Testing

• If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
• If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

• Include any change that might be observable by our partners or affect their deployment in the release notes.
• Specify fixed issues with Fixes #n, and mention issues worked on using #n
• Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

• Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

[timpel-fcs]

see #1915

[timpel-fcs]

see #1915

[martinflorian-da]

Very nice, thanks a lot! Beyond my comments here (and whatever else CI might think of): you need to fix your commit messages and force push: https://github.com/hyperledger-labs/splice/pull/1939/checks?check_run_id=48299437971

(I'll probably approve + merge in the end in one go; please ping me once you consider the PR ready to merge.)

[martinflorian-da]

Is this context being used for anything?

[timpel-fcs]

If I am not mistaken it is necessary for the recursive call of the function so as not to lose the original context

[martinflorian-da]

I was curious about this and tried it out. This simpler variant (without context) seems to work with the current unit test and also if I add more nesting:

> gd
diff --git a/cluster/helm/splice-participant/templates/participant.yaml b/cluster/helm/splice-participant/templates/participant.yaml
index 1eeded5c4..343c9c069 100644
--- a/cluster/helm/splice-participant/templates/participant.yaml
+++ b/cluster/helm/splice-participant/templates/participant.yaml
@@ -69,7 +69,7 @@ spec:
             canton.participants.participant.crypto {
               provider = kms
               kms = {
-                {{- include "splice-util-lib.render-nested-config" (dict "context" . "nestedConfig" .Values.kms) | trim | nindent 16 }}
+                {{- include "splice-util-lib.render-nested-config" .Values.kms | trim | nindent 16 }}
               }
             }
         {{- end }}
diff --git a/cluster/helm/splice-util-lib/templates/_helpers.tpl b/cluster/helm/splice-util-lib/templates/_helpers.tpl
index cf00d7781..14264dd93 100644
--- a/cluster/helm/splice-util-lib/templates/_helpers.tpl
+++ b/cluster/helm/splice-util-lib/templates/_helpers.tpl
@@ -229,11 +229,9 @@ app: {{ .app }}
 {{- end }}
 {{- end -}}
 {{- define "splice-util-lib.render-nested-config" }}
-{{- $context := .context -}}
-{{- $nestedConfig := .nestedConfig -}}
-{{- range $key, $value := $nestedConfig }}
+{{- range $key, $value := . }}
 {{ $key | kebabcase }} = {{- if kindIs "map" $value }} {
-{{- include "splice-util-lib.render-nested-config" (dict "context" $context "nestedConfig" $value) | trim | nindent 2 }}
+{{- include "splice-util-lib.render-nested-config" $value | trim | nindent 2 }}
 }
 {{- else }} {{ $value }}
 {{- end }}

Without clear evidence that we need I'd suggest going for simpler solution. Also makes "calling" this partial template more convenient.

[timpel-fcs]

Alright done, you are correct also tested on my end again and added another unittest for recursive mapping as well to the participant test values

[martinflorian-da]

nit: You can also move the generic part of the set to the top of the file I believe (so under .set); less duplication.

(I found out about this late, otherwise I would have used it also for the things that already exist here; feel free to refactor also the existing parts if you feel like it but not a PR blocker for me for sure.)

[timpel-fcs]

done

[martinflorian-da]

confusing comment

[timpel-fcs]

adjusted

[martinflorian-da]

Happy to approve now, thanks a lot for contributing!