Migrate from reference driver to BFT driver #1975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzkiefer-da
force-pushed
the
cocreature/bft-migration
branch
17 times, most recently
from
faa6d6b to
6124f9c
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
force-pushed
the
cocreature/bft-migration
branch
from
6124f9c to
fa8af18
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
force-pushed
the
cocreature/bft-migration
branch
from
6c2497c to
297eb69
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
commented
Aug 27, 2025
| TraceContext.withNewTraceContext("beforeEnvironmentDestroyed") { implicit tc => | ||
| // A scan might not be initialized if the test uses `manualStart` and it wasn't ever started. | ||
| val initializedScans = environment.scans.local.filter(scan => scan.is_initialized) | ||
| logger.debug(s"Checking update histories for ${initializedScans.map(_.name)}") |
There was a problem hiding this comment.
just some extra logs I found useful for debugging
| "SECOND_EXTRA_PARTICIPANT_DB" -> s"participant_second_extra_${dbsSuffix}", | ||
| "SECOND_EXTRA_PARTICIPANT_ADMIN_USER" -> splitwellValidatorBackend.config.ledgerApiUser, | ||
| ), | ||
| enableBftSequencer = true, |
There was a problem hiding this comment.
We probably want to eventually change this to do bft => bft but for now I'd just hardcode it this way. This is the only really relevant migration and given how long it took me to get it green I'd ensure that it stays green not just through the optional bft tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines