Don't bump splice ports in migration test #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzkiefer-da
force-pushed
the
cocreature/migration-ports
branch
from
4eb0e24 to
db27a94
Compare
This doesn't work for BFT nodes as the scan URLs cannot be updated before unpausing the synchronizer and we need the scan URLs for BFT peers. [ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
force-pushed
the
cocreature/migration-ports
branch
from
db27a94 to
95d3281
Compare
moritzkiefer-da
force-pushed
the
cocreature/migration-ports
branch
from
df2eb74 to
1c72627
Compare
[ci] This reverts commit 95d3281. Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
changed the title
moritzkiefer-da
commented
Aug 25, 2025
| .addConfigTransforms((_, conf) => | ||
| (ConfigTransforms | ||
| .bumpSomeSvAppPortsBy( | ||
| .bumpSomeSvAppCantonPortsBy( |
There was a problem hiding this comment.
The port configuration is a giant mess in this test between the config transforms here and hardcoded ports above. I'll keep it as is for this PR but will probably clean it up in another one if I find some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work for BFT nodes as the scan URLs cannot be updated before unpausing the synchronizer and we need the scan URLs for BFT peers.
[ci]
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines