Remove config transform to bump canton domain ports #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci] The split here doesn't really make sense. The one without "domain" in the name bumps the internal API URL. The one with domain in the name bumps the external API URL. Clearly both are domain related. And we always set both because otherwise you get a mismatch since internal and external are the same in integration tests. Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
moritzkiefer-da
force-pushed
the
cocreature/port-configs
branch
from
f602ce6 to
5976753
Compare
nicu-da
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci]
The split here doesn't really make sense. The one without "domain" in the name bumps the internal sequencer API URL. The one with domain in the name bumps the external API URL. Clearly both are domain related. And we always set both because otherwise you get a mismatch since internal and external are the same in integration tests.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines