Skip to content

fix exposing secret to the non-root images #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2025
Merged

fix exposing secret to the non-root images #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
807842c
[static] fix exposing secret to the non-root images
isegall-da Sep 30, 2025
4033e3f
[static] also in validator
isegall-da Sep 30, 2025
35da316
wanna cry
isegall-da Sep 30, 2025
96bb0e9
manage the symlinks
isegall-da Sep 30, 2025
bfd17bd
[static]
isegall-da Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions cluster/helm/splice-sv-node/templates/sv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,24 +414,28 @@ spec:
{{- if .Values.participantIdentitiesDumpImport }}
- name: chown-participant-bootstrapping-dump
image: busybox:1.37.0
command: ["sh", "-c", "chown -R 1001:1001 /participant-bootstrapping-dump"]
command: ["sh", "-c", "cp /participant-bootstrapping-dump-secret/content /participant-bootstrapping-dump/ && chown -R 1001:1001 /participant-bootstrapping-dump"]
volumeMounts:
- name: participant-bootstrapping-dump-secret
mountPath: /participant-bootstrapping-dump-secret
- name: participant-bootstrapping-dump-volume
mountPath: /participant-bootstrapping-dump
{{- end }}
{{- if .Values.migration.attachPvc }}
- name: chown-domain-upgrade-dump
image: busybox:1.37.0
command: ["chown", "-R", "1001:1001", "/domain-upgrade-dump"]
command: ["sh", "-c", "chown -R 1001:1001 /domain-upgrade-dump"]
volumeMounts:
- name: domain-upgrade-dump-volume
mountPath: /domain-upgrade-dump
{{- end }}
volumes:
{{- with .Values.participantIdentitiesDumpImport }}
- name: participant-bootstrapping-dump-volume
- name: participant-bootstrapping-dump-secret
secret:
secretName: {{ .secretName }}
- name: participant-bootstrapping-dump-volume
emptyDir: {}
{{- end }}
{{- if .Values.migration.attachPvc }}
- name: domain-upgrade-dump-volume
Expand Down
8 changes: 6 additions & 2 deletions cluster/helm/splice-validator/templates/validator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,11 @@ spec:
{{- if or .Values.participantIdentitiesDumpImport $requiresMigrationPvc }}
volumes:
{{- with .Values.participantIdentitiesDumpImport }}
- name: participant-bootstrapping-dump-volume
- name: participant-bootstrapping-dump-secret
secret:
secretName: {{ .secretName }}
- name: participant-bootstrapping-dump-volume
emptyDir: {}
{{- end }}
{{- if $requiresMigrationPvc }}
- name: domain-upgrade-dump-volume
Expand Down Expand Up @@ -361,8 +363,10 @@ spec:
{{- if .Values.participantIdentitiesDumpImport }}
- name: chown-participant-bootstrapping-dump
image: busybox:1.37.0
command: ["sh", "-c", "chown -R 1001:1001 /participant-bootstrapping-dump"]
command: ["sh", "-c", "cp /participant-bootstrapping-dump-secret/content /participant-bootstrapping-dump/ && chown -R 1001:1001 /participant-bootstrapping-dump"]
volumeMounts:
- name: participant-bootstrapping-dump-secret
mountPath: /participant-bootstrapping-dump-secret
- name: participant-bootstrapping-dump-volume
mountPath: /participant-bootstrapping-dump
{{- end }}
Expand Down