Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

fix: didexchange handle inbound oob invitations#1630

Merged
fqutishat merged 1 commit intohyperledger-aries:masterfrom
llorllale:fix_didexchange_request
Apr 15, 2020
Merged

fix: didexchange handle inbound oob invitations#1630
fqutishat merged 1 commit intohyperledger-aries:masterfrom
llorllale:fix_didexchange_request

Conversation

@llorllale
Copy link
Contributor

This PR fixes the following bugs in the didexchange protocol service when responding to oob invitations:

  • label not set in outgoing request
  • new recipient keys not registered in the router

Signed-off-by: George Aristy george.aristy@securekey.com

* set label on outgoing request
* register new recipient keys in the router

Signed-off-by: George Aristy <george.aristy@securekey.com>
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #1630 into master will increase coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   91.20%   91.24%   +0.03%     
==========================================
  Files         164      164              
  Lines       11633    11624       -9     
==========================================
- Hits        10610    10606       -4     
+ Misses        582      579       -3     
+ Partials      441      439       -2     
Impacted Files Coverage Δ
pkg/didcomm/protocol/didexchange/states.go 92.54% <87.50%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822f963...0bf4663. Read the comment docs.

@fqutishat fqutishat merged commit 3d5b22a into hyperledger-aries:master Apr 15, 2020
@llorllale llorllale deleted the fix_didexchange_request branch April 15, 2020 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants