This repository was archived by the owner on Mar 27, 2024. It is now read-only.
feat: outofband events#1635
Merged
troyronda merged 1 commit intohyperledger-aries:masterfrom Apr 16, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
+ Coverage 91.29% 91.35% +0.05%
==========================================
Files 164 164
Lines 11698 11724 +26
==========================================
+ Hits 10680 10710 +30
+ Misses 579 576 -3
+ Partials 439 438 -1
Continue to review full report at Codecov.
|
Signed-off-by: George Aristy <george.aristy@securekey.com>
llorllale
force-pushed
the
outofband_events_actions
branch
from
1575b7c to
b3ba91d
Compare
llorllale
requested review from
baha-ai,
kdimak,
rolsonquadras,
sandrask,
soluchok,
sudeshrshetty and
troyronda
soluchok
approved these changes
Apr 16, 2020
rolsonquadras
approved these changes
Apr 16, 2020
troyronda
approved these changes
Apr 16, 2020
soluchok
reviewed
Apr 16, 2020
Comment on lines
+183
to
+188
| var stateName string | ||
|
|
||
| if msg.Type() == RequestMsgType { | ||
| stateName = StateRequested | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I am a bit confused about that piece of code. It seems like StateID can be empty. Is that expected behavior?
Contributor
Author
There was a problem hiding this comment.
@soluchok this should be refactored after the oob invitation msg type is added to the service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1568
Signed-off-by: George Aristy george.aristy@securekey.com