fix(cheqd): make cosmos payer seed optional#1547
Merged
TimoGlastra merged 2 commits intoopenwallet-foundation:mainfrom Aug 18, 2023
Merged
fix(cheqd): make cosmos payer seed optional#1547TimoGlastra merged 2 commits intoopenwallet-foundation:mainfrom
TimoGlastra merged 2 commits intoopenwallet-foundation:mainfrom
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
berendsliedrecht
approved these changes
Aug 18, 2023
Signed-off-by: Timo Glastra <timo@animo.id>
Contributor
Author
|
@berendsliedrecht can you re-review. I also added an overwrite of the |
berendsliedrecht
approved these changes
Aug 18, 2023
Contributor
Ideally only for the cheqd specific dependencies. Since you would do this in your app anyways to make it work, I think it is okay. |
Codecov Report
@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
+ Coverage 84.34% 85.73% +1.39%
==========================================
Files 950 950
Lines 22743 22744 +1
Branches 3977 3978 +1
==========================================
+ Hits 19183 19500 +317
+ Misses 3337 3059 -278
+ Partials 223 185 -38
|
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Martin Auer <martin.auer97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the cosmos payer seed optional, as you can also used it as a holder without payer seed.