feat: Issue Credentials V2: W3C/ jsonld credentials #795
Conversation
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Karim <karim@animo.id>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Karim <karim@animo.id>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Karim <karim@animo.id>
Signed-off-by: Karim <karim@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Karim <karim@animo.id>
Signed-off-by: Karim <karim@animo.id>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Merge AFJ main -> feat/jsonld-credentials
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Merge AFJ Main -> feat/jsonld-credentials
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
AFJ Main -> feat/jsonld-credentials
|
This is urgent (to be merged) as it costs @NB-MikeRichardson a lot of overhead. |
fix(connections): do not log AgentContext object (openwallet-foundation#1085)
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
| createProposal: SignCredentialOptionsRFC0593 | ||
| acceptProposal: SignCredentialOptionsRFC0593 | ||
| createOffer: SignCredentialOptionsRFC0593 | ||
| acceptOffer: SignCredentialOptionsRFC0593 | ||
| createRequest: SignCredentialOptionsRFC0593 | ||
| acceptRequest: JsonLdAcceptRequestOptions |
There was a problem hiding this comment.
The acceptXXX methods can take the values from the previous message. So if I receive a proposal and I agree with the contents of it, I call acceptProposal. What this will do is take the contents of the proposal and put those in the request. If i don't agree I will call negotiateProposal, which will in turn call createOffer.
So the types for acceptXX can be a lot simpler than createXXX. I'm fine with merging this PR now, but that means we'll have breaking changes soon to better differntiate between accept and create. We can mark the JSON ld api as experimental
packages/core/src/modules/credentials/formats/jsonld/JsonLdCredentialOptions.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/credentials/formats/jsonld/JsonLdCredentialOptions.ts
Show resolved
Hide resolved
packages/core/src/modules/dids/domain/key-type/keyDidMapping.ts
Outdated
Show resolved
Hide resolved
|
|
||
| import { SubjectInboundTransport } from '../../../tests/transport/SubjectInboundTransport' | ||
| import { SubjectOutboundTransport } from '../../../tests/transport/SubjectOutboundTransport' | ||
| import { BbsModule } from '../../bbs-signatures/src/BbsModule' |
There was a problem hiding this comment.
Why do we need the dependency on bbs here? It's fine for now, but ideally we only depend from bbs on core, not vice versa (also in tests)
There was a problem hiding this comment.
I am using the BbsModule here to set up agent modules in setting up e2e credential tests.
Is there some way to avoid this? Maybe we need to move the agent set up out of helper.ts...??
packages/core/src/modules/credentials/formats/jsonld/JsonLdCredentialFormatService.ts
Show resolved
Hide resolved
|
Last remarks, then we can merge |
Yes this has been outstanding for way too long. Sorry on this from my side for reviewing it slowly. I think as discussed before: smaller PRs that are easier to review. As a tip to you in the future Mike, please read the RFC carefully and handle all edge cases before making a PR. This will save me a lot of time in reviewing, and save you a lot of time in doing multiple round trips. |
|
Advice on reading RFCs more carefully noted. I will get these done asap. Please can you raise an issue with all these small issues that need to be done 'post merge.' I am happy to work on them. I have raised the issue: Issue #1089 |
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
10 participants
Merge of jsonld-credentials -> 0.3.0-pre