Skip to content

chore: upgrade to react native 0.72#960

Merged
cvarjao merged 25 commits intoopenwallet-foundation:mainfrom
cvarjao:RN72
Sep 29, 2023
Merged

chore: upgrade to react native 0.72#960
cvarjao merged 25 commits intoopenwallet-foundation:mainfrom
cvarjao:RN72

Conversation

@cvarjao
Copy link
Contributor

@cvarjao cvarjao commented Sep 7, 2023

Summary of Changes

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

@cvarjao cvarjao force-pushed the RN72 branch 2 times, most recently from 14712dd to 1c78bf0 Compare September 13, 2023 01:37
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #960 (ab708a6) into main (0098986) will not change coverage.
The diff coverage is 95.23%.

@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   59.24%   59.24%           
=======================================
  Files         176      176           
  Lines        5084     5084           
  Branches     1451     1451           
=======================================
  Hits         3012     3012           
  Misses       2046     2046           
  Partials       26       26           
Files Coverage Δ
...ages/legacy/core/App/components/buttons/Button.tsx 87.50% <ø> (ø)
...ges/legacy/core/App/components/inputs/PINInput.tsx 80.00% <100.00%> (ø)
...ckages/legacy/core/App/components/misc/InfoBox.tsx 92.98% <100.00%> (ø)
...ages/legacy/core/App/components/misc/QRScanner.tsx 42.85% <100.00%> (ø)
...legacy/core/App/components/misc/QRScannerTorch.tsx 18.75% <ø> (ø)
...y/core/App/components/modals/CommonRemoveModal.tsx 94.25% <ø> (ø)
...legacy/core/App/components/record/RecordFooter.tsx 100.00% <100.00%> (ø)
...legacy/core/App/components/record/RecordHeader.tsx 100.00% <100.00%> (ø)
packages/legacy/core/App/contexts/auth.tsx 4.54% <100.00%> (ø)
packages/legacy/core/App/contexts/commons.tsx 27.27% <100.00%> (ø)
... and 7 more

... and 6 files with indirect coverage changes

@cvarjao cvarjao force-pushed the RN72 branch 2 times, most recently from b568e79 to 8eac2a5 Compare September 19, 2023 01:17
@cvarjao cvarjao marked this pull request as ready for review September 26, 2023 22:17
@cvarjao cvarjao requested a review from a team September 26, 2023 22:17
MosCD3
MosCD3 previously approved these changes Sep 26, 2023
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
./gradlew app:dependencies --write-locks

https: //citymall.engineering/towards-reproducible-android-apps-locking-gradle-dependencies-c0ff2eaacde2
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
Signed-off-by: Clécio Varjão <1348549+cvarjao@users.noreply.github.com>
@cvarjao cvarjao merged commit b5c7cb7 into openwallet-foundation:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants