Skip to content

Conversation

@uday03meh
Copy link
Contributor

@uday03meh uday03meh commented Dec 22, 2022

Signed-off-by: Uday Mehtani udaymehtani@gmail.com

Pull request checklist

Use the following list to make sure your PR fits the Besu documentation quality standard.

Before creating the pull request

Make sure that:

Describe the change

Formatted the JSON code properly

Issue fixed

fixes #1216

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Github Actions workflow
  • Build and QA tools configuration (for example, lint rules or Vale style)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

Preview Link

Before

image

After merging this PR

image

@uday03meh uday03meh requested a review from a team as a code owner December 22, 2022 15:39
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good @uday03meh but it's missing the signoff - this needs to be fixed so it can pass the DCO check https://github.com/hyperledger/besu-docs/pull/1230/checks?check_run_id=10257396134

Signed-off-by: Uday Mehtani <udaymehtani@gmail.com>
@uday03meh
Copy link
Contributor Author

Hi, Can you please let me know if this is good else I can close this Pull Request and submit a new one with same changes.

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thanks!

@macfarla macfarla merged commit fdd053b into hyperledger:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Content] Json markup syntax error

3 participants