Add eth_config method documentation. #1850
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
@bgravenorst maybe it is worth clarifying that the furthest known fork into the future. futuremost? idk how best to say it but "last" is ambiguous. I know that's what they use in the spec. Otherwise LGTM |
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
alexandratran
approved these changes
Oct 17, 2025
Comment on lines
+2529
to
+2531
| - `next`: _object_ or _null_ - next fork configuration. `null` if no future fork is scheduled. | ||
| - `last`: _object_ or _null_ - the furthest configured future fork configuration (the future fork with | ||
| the largest `activationTime` among the client’s configured forks). If only one future fork is configured, `next` and `last` are the same object. `null` if no future fork is scheduled. |
There was a problem hiding this comment.
Suggested change
| - `next`: _object_ or _null_ - next fork configuration. `null` if no future fork is scheduled. | |
| - `last`: _object_ or _null_ - the furthest configured future fork configuration (the future fork with | |
| the largest `activationTime` among the client’s configured forks). If only one future fork is configured, `next` and `last` are the same object. `null` if no future fork is scheduled. | |
| - `next`: _object_ - next fork configuration, or `null` if no future fork is scheduled. | |
| - `last`: _object_ - the furthest configured future fork configuration (the future fork with | |
| the largest `activationTime` among the client's configured forks). If only one future fork is configured, `next` and `last` are the same object. `null` if no future fork is scheduled. |
Minor edit for consistency with other method param descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for the
eth_configmethod.Issue(s) fixed
Fixes #1849
Preview
https://besu-docs-git-fork-bgravenorst-doc-1849-hyperledger.vercel.app/public-networks/reference/api#eth_config