update PR template #572
Merged
update PR template #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
MadelineMurray
approved these changes
Dec 14, 2020
macfarla
reviewed
Dec 14, 2020
|
|
||
| - [ ] you fixed all the issues raised by the tests, if any. | ||
| - [ ] you verified the rendering of your changes on [ReadTheDocs.org PR preview](https://wiki.hyperledger.org/display/BESU/MkDocs+And+Markdown+Guide#MkDocsAndMarkdownGuide-PreviewwithReadTheDocs) | ||
| and updated the testing link (see [Testing](#testing)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Use the following list to make sure your PR fits the Besu doc quality standard.
Before creating the pull request
Make sure that:
After creating your pull request and tests finished
Make sure that:
and updated the testing link (see Testing).
Describe the change
Update the PR template to make the checklist more explicit and split the list into before PR and after PR creation.
Issue fixed
No issue created just for this, only some discussion.
Impacted parts
For content changes
For tools changes
Testing
this PR description uses the modified template