Skip to content

Conversation

@alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Mar 22, 2021

Pull request checklist

Use the following list to make sure your PR fits the Besu doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you fixed all the issues raised by the tests, if any.
  • you verified the rendering of your changes on ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

Add Astor testnet to docs.

Issue fixed

fixes #632

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

Screenshots / recording

@alexandratran alexandratran requested a review from a team as a code owner March 22, 2021 21:06
Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
@alexandratran alexandratran force-pushed the 632_doc_add_astor_testnet branch from b57e323 to 2f678c3 Compare March 22, 2021 21:10
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NicolasMassart NicolasMassart merged commit 1dffb2c into hyperledger:master Mar 23, 2021
@alexandratran alexandratran deleted the 632_doc_add_astor_testnet branch March 23, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Astor test

3 participants