Clarify onchain account permissioning behaviour. #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
Signed-off-by: Byron Gravenorst <byron.gravenorst@consensys.net>
NicolasMassart
approved these changes
Apr 6, 2021
Comment on lines
+13
to
+15
| Nodes validate account permissions when importing blocks. This means if you disable onchain | ||
| account permissioning and add transactions to the chain, nodes cannot resync the network if | ||
| account permissioning is re-enabled. |
Member
There was a problem hiding this comment.
I think I'd rephrase this a bit:
When using Onchain Account Permissioning, the node will check permissions when importing blocks. This means that only blocks in which all transactions are from authorized senders will be deemed valid and imported. If you disable Onchain Account Permissioning and your node accept blocks without enforcing this rule, your node will not be able to resync with other nodes that are enforcing Onchain Account Permissioning rules (your node will be in a forked state).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Use the following list to make sure your PR fits the Besu doc quality standard.
Before creating the pull request
Make sure that:
Describe the change
Clarify onchain account permissioning behaviour.
Issue fixed
Fixes #610
Impacted parts
For content changes