Skip to content

Conversation

@alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Jan 10, 2022

Signed-off-by: Alexandra Tran alexandra.tran@consensys.net

Pull request checklist

Use the following list to make sure your PR fits the Besu doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you fixed all the issues raised by the tests, if any.
  • you verified the rendering of your changes on ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

Add more context and info about discovery to the Manage Peers page. Also edit throughout the page and rearrange the sections.

Issue fixed

fixes #914

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

https://hyperledger-besu--917.org.readthedocs.build/en/917/HowTo/Find-and-Connect/Managing-Peers/

Screenshots / recording

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
@alexandratran alexandratran requested a review from a team as a code owner January 10, 2022 08:03
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improvement

Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions added

Signed-off-by: Alexandra Tran <alexandra.tran@consensys.net>
@alexandratran alexandratran merged commit 6839e9d into hyperledger:main Jan 12, 2022
@alexandratran alexandratran deleted the 914-discovery branch January 12, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve docs around discovery options

5 participants