Skip to content

Add broadcast address to PingPacketData from filter#6456

Merged
garyschulte merged 2 commits intobesu-eth:mainfrom
garyschulte:bugfix/noisy-discovery-on-broadcast-address
Jan 24, 2024
Merged

Add broadcast address to PingPacketData from filter#6456
garyschulte merged 2 commits intobesu-eth:mainfrom
garyschulte:bugfix/noisy-discovery-on-broadcast-address

Conversation

@garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Jan 24, 2024

PR description

address another pathological default PingPacketData from address we are seeing on mainnet - a broadcast address 255.255.255.255 seems to be a default value for some implementations.

For example we are seeing a lot of these log lines on mainnet:

{
   "@timestamp":"2024-01-24T06:18:16,129",
   "level":"WARN",
   "thread":"vert.x-eventloop-thread-3",
   "class":"VertxPeerDiscoveryAgent",
   "message":"Sending to peer DiscoveryPeer{status=bonding, enode=enode://5d01e72875f3485fdcce5255720696087ea7d704c6632282fbe39329db6417a6f5ef940cf05519677be7f9c31b6b553fe9192e9e9feed37db3fb97bcc7fd099e@255.255.255.255:30313, firstDiscovered=1706077069751, lastContacted=0, lastSeen=1706077069751} failed, native error code -13, packet: 0x3123aed37feabe25bd4cc2625a1d1e2b12a5a1bbe6f3ef594c1ea76abbfbae670ab30477655186a5a3bf4487f2fa183807dad26037e950e89cc07ba20eaf229437e69c2e56d44fe934082147098ca4a0bd99964d67d2046789d080f69d5be2c60101df05cb8489757c7882765f82765fcb84ffffffff8276698276698465b0abe402, stacktrace: io.netty.channel.unix.Errors$NativeIoException: sendToAddress(..) failed: Permission denied",
   "throwable":""
}

the functional change is minimal, but rearranges the host detection to be in a unit testable method.

Fixed Issue(s)

related to #6224

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte force-pushed the bugfix/noisy-discovery-on-broadcast-address branch from 1199690 to 59ba063 Compare January 24, 2024 17:46
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix & refactoring

@garyschulte garyschulte merged commit 30958e6 into besu-eth:main Jan 24, 2024
@garyschulte garyschulte deleted the bugfix/noisy-discovery-on-broadcast-address branch January 24, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants