Add broadcast address to PingPacketData from filter#6456
Merged
garyschulte merged 2 commits intobesu-eth:mainfrom Jan 24, 2024
Merged
Conversation
|
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
1199690 to
59ba063
Compare
jflo
approved these changes
Jan 24, 2024
matthew1001
approved these changes
Jan 24, 2024
Contributor
matthew1001
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix & refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
address another pathological default PingPacketData from address we are seeing on mainnet - a broadcast address 255.255.255.255 seems to be a default value for some implementations.
For example we are seeing a lot of these log lines on mainnet:
the functional change is minimal, but rearranges the host detection to be in a unit testable method.
Fixed Issue(s)
related to #6224