info level log for pipeline abort#6459
Merged
garyschulte merged 5 commits intobesu-eth:mainfrom Jan 30, 2024
Merged
Conversation
|
macfarla
approved these changes
Jan 24, 2024
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
suggestion to add a comment to make it obvious we want this stacktrace at info level
| } else { | ||
| LOG.info("Unexpected exception in pipeline. Aborting."); | ||
| LOG.debug("Unexpected exception in pipeline. Aborting.", t); | ||
| LOG.info("Unexpected exception in pipeline. Aborting.", t); |
Contributor
There was a problem hiding this comment.
// log the stacktrace at info to help troubleshoot sync stuck issues
Contributor
Author
There was a problem hiding this comment.
maybe it should be at warn actually
garyschulte
force-pushed
the
test/log-pipeline-abort
branch
from
68b4ab1 to
252e3c3
Compare
jflo
approved these changes
Jan 30, 2024
Contributor
jflo
left a comment
jflo
left a comment
There was a problem hiding this comment.
Suggested improvement, non-blocking.
| StackTraceElement[] stackTraceElements = throwable.getStackTrace(); | ||
|
|
||
| List<String> stackTraceSummary = new ArrayList<>(); | ||
| for (StackTraceElement element : stackTraceElements) { |
Contributor
There was a problem hiding this comment.
maybe add some kind of bailout in case of a crazy long loop or recursion stack?
Contributor
Author
There was a problem hiding this comment.
added a max depth of 20, since this is supposed to be a summary 👍
garyschulte
force-pushed
the
test/log-pipeline-abort
branch
from
80a5161 to
23f1e13
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
… pipeline abort use summarize Stack at info level Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
test/log-pipeline-abort
branch
from
23f1e13 to
e7d5bac
Compare
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 30, 2024
* info level log for pipeline abort * add depth protection Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 30, 2024
* info level log for pipeline abort * add depth protection Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jan 30, 2024
* info level log for pipeline abort * add depth protection Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Add a summarize stack log util, use it in Pipeline to summarize abort errors at an info level
Fixed Issue(s)