Skip to content

[Refactor] - Extract websocket options to a new class#6461

Merged
Gabriel-Trintinalia merged 5 commits intobesu-eth:mainfrom
Gabriel-Trintinalia:6428-besucommand-ws
Jan 25, 2024
Merged

[Refactor] - Extract websocket options to a new class#6461
Gabriel-Trintinalia merged 5 commits intobesu-eth:mainfrom
Gabriel-Trintinalia:6428-besucommand-ws

Conversation

@Gabriel-Trintinalia
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia commented Jan 25, 2024 •
edited
Loading

PR description

[Refactor] - Extract web socket options to a new class

  • Moves the web socket cli options to its own class.
  • same for related tests

Fixed Issue(s)

see #6428

@Gabriel-Trintinalia
Move websocket options to own class
c4963da 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Code organisation
94c8559 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Rename class
67708e8 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@github-actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited by Gabriel-Trintinalia
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@Gabriel-Trintinalia
add javadoc
58a7021 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
macfarla
macfarla approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) January 25, 2024 02:30
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 317d2ac into besu-eth:main Jan 25, 2024
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 6428-besucommand-ws branch January 23, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macfarla macfarla macfarla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gabriel-Trintinalia @macfarla