Skip pruning if trie log count is less than retention limit#6463
Merged
siladu merged 3 commits intobesu-eth:mainfrom Jan 25, 2024
Merged
Skip pruning if trie log count is less than retention limit#6463siladu merged 3 commits intobesu-eth:mainfrom
siladu merged 3 commits intobesu-eth:mainfrom
Conversation
Rework error messaging in this case. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
|
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
gfukushima
reviewed
Jan 25, 2024
besu/src/main/java/org/hyperledger/besu/cli/subcommands/storage/TrieLogHelper.java
Show resolved
Hide resolved
gfukushima
reviewed
Jan 25, 2024
besu/src/test/java/org/hyperledger/besu/cli/subcommands/storage/TrieLogHelperTest.java
Show resolved
Hide resolved
gfukushima
approved these changes
Jan 25, 2024
Contributor
Author
|
Tested on holesky... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework error messaging in this case.
This can occur if pruning is attempted before the node has reached the configured retention limit (512 by default)
PR description
Fixed Issue(s)