Skip to content

[Refactor] - Extract JsonRpcHttpOptions to a new class #6478

Merged
Gabriel-Trintinalia merged 8 commits intobesu-eth:mainfrom
Gabriel-Trintinalia:6428-json-http-options
Jan 29, 2024
Merged

[Refactor] - Extract JsonRpcHttpOptions to a new class #6478
Gabriel-Trintinalia merged 8 commits intobesu-eth:mainfrom
Gabriel-Trintinalia:6428-json-http-options

Conversation

@Gabriel-Trintinalia
Copy link
Contributor

PR description

[Refactor] - Extract JsonRpcHttpOptions to a new class

Moves the JsonRpcHttpOptions cli options to its own class.
same for related tests

see #6428

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@github-actions
Copy link

github-actions bot commented Jan 29, 2024

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) January 29, 2024 02:40
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit e55569c into besu-eth:main Jan 29, 2024
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 6428-json-http-options branch January 23, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants