Filter Discovered peers for ipv6 support#6498
Merged
garyschulte merged 10 commits intobesu-eth:mainfrom Jan 31, 2024
Merged
Conversation
|
garyschulte
force-pushed
the
bugfix/discovery-ipv6-errors
branch
from
b9d08c7 to
ebf915b
Compare
garyschulte
force-pushed
the
bugfix/discovery-ipv6-errors
branch
from
d9d5aab to
260d6b4
Compare
pinges
approved these changes
Jan 31, 2024
Contributor
pinges
left a comment
pinges
left a comment
There was a problem hiding this comment.
Left two comments, but LGTM
| .orElseGet(sourceEndpoint::getHost); | ||
| .orElseGet( | ||
| () -> { | ||
| LOG.trace( |
Contributor
There was a problem hiding this comment.
LOG.atTrace would be nice ...
Contributor
Author
There was a problem hiding this comment.
since this is already in a lambda, the extra log lambda isn't necessary :)
Contributor
Author
There was a problem hiding this comment.
oh wait, yeah. you are right! I originally had this logging every time, but it was noisy and moved it to trace
| @@ -173,4 +196,20 @@ private static boolean isPortAvailableForUdp(final int port) { | |||
| public static boolean isPortAvailable(final int port) { | |||
Contributor
There was a problem hiding this comment.
I've had a look at the isPortAvailableFor[Tcp|Udp] and I thought that we might want to close the ServerSocket if we successfully binded to it?
Contributor
Author
There was a problem hiding this comment.
Apparently SO_REUSEADDR makes it moot, but I don't see why we wouldn't unbind. It isn't in the scope of this PR, but I can put up a subsequent one.
…ltering, add ipv6 check/fallback Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/discovery-ipv6-errors
branch
from
260d6b4 to
7dc8bc7
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
bugfix/discovery-ipv6-errors
branch
from
1757144 to
59da07a
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Gabriel-Trintinalia
pushed a commit
to Gabriel-Trintinalia/besu
that referenced
this pull request
Feb 1, 2024
* use existing NetworkUtility for PeerDiscoveryAgent pingpacket data filtering, add ipv6 check/fallback * log at debug when we override pingpacket from * use java native address parsing rather than lookup by host Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
updates PeerDiscoveryAgent to
Fixed Issue(s)
fixes #6475