Skip to content

[MINOR] remove duplicate setting of default values for CLI options#6500

Merged
macfarla merged 1 commit intobesu-eth:mainfrom
macfarla:dup-defaults-cli
Jan 31, 2024
Merged

[MINOR] remove duplicate setting of default values for CLI options#6500
macfarla merged 1 commit intobesu-eth:mainfrom
macfarla:dup-defaults-cli

Conversation

@macfarla
Copy link
Contributor

where the default is number/boolean/string, just leave it to the initialized value for the actual field.

same as was done for Sync Options in #6499

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) January 31, 2024 02:17
@macfarla macfarla merged commit 20c713b into besu-eth:main Jan 31, 2024
Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Feb 1, 2024
…6500)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@macfarla macfarla deleted the dup-defaults-cli branch February 6, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants