Fix builds & permit daily builds to occur #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
mbwhite
changed the title
Contributor
mastersingh24
left a comment
mastersingh24
left a comment
There was a problem hiding this comment.
Do we really need a nightly driver?
| displayName: 'Chaincode Java Nightly Driver' | ||
| branches: | ||
| include: | ||
| - master |
Contributor
There was a problem hiding this comment.
do we need master in here?
Member
Author
Previously (and this applies to other languages) - each merge build did a full publish to npmjs, maven, docker hub etc... that's a lot of published drivers that aren't ever going to be used. Nightly can properly publish a build - and also lets us do more 'soak' testing if needed,. |
mastersingh24
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in Azure schedule
Signed-off-by: Matthew B White whitemat@uk.ibm.com