Skip to content
This repository was archived by the owner on Apr 22, 2025. It is now read-only.

Commit d69047f

Browse files
committed
FABJ-411 Enable service disc IT build verify
Change-Id: I64fafb807f47ffe8c07d6ad575bbb1101a341dbf Signed-off-by: rickr <cr22rc@gmail.com>
1 parent d2bc6d5 commit d69047f

File tree

3 files changed

+23
-3
lines changed

3 files changed

+23
-3
lines changed

src/test/cirun.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ export ORG_HYPERLEDGER_FABRIC_SDKTEST_DEPLOYWAITTIME=1300000
3131
export ORG_HYPERLEDGER_FABRIC_SDKTEST_PROPOSALWAITTIME=300000
3232

3333
export ORG_HYPERLEDGER_FABRIC_SDKTEST_RUNIDEMIXMTTEST=true
34+
export ORG_HYPERLEDGER_FABRIC_SDKTEST_RUNSERVICEDISCOVERYIT=true
35+
echo '----- etc/hosts -------'
36+
cat /etc/hosts
37+
echo '----- etc/hosts -------'
38+
3439

3540
ORG_HYPERLEDGER_FABRIC_SDKTEST_VERSION=${ORG_HYPERLEDGER_FABRIC_SDKTEST_VERSION:-}
3641
ORG_HYPERLEDGER_FABRIC_SDKTEST_FIXVERSION=${ORG_HYPERLEDGER_FABRIC_SDKTEST_FIXVERSION:-}

src/test/java/org/hyperledger/fabric/sdk/testutils/TestConfig.java

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,10 @@ public class TestConfig {
6363
private static final String DEPLOYWAITTIME = PROPBASE + "DeployWaitTime";
6464
private static final String PROPOSALWAITTIME = PROPBASE + "ProposalWaitTime";
6565
private static final String RUNIDEMIXMTTEST = PROPBASE + "RunIdemixMTTest"; // org.hyperledger.fabric.sdktest.RunIdemixMTTest ORG_HYPERLEDGER_FABRIC_SDKTEST_RUNIDEMIXMTTEST
66+
private static final String RUNSERVICEDISCOVERYIT = PROPBASE + "runServiceDiscoveryIT"; // org.hyperledger.fabric.sdktest.RunIdemixMTTest ORG_HYPERLEDGER_FABRIC_SDKTEST_RUNIDEMIXMTTEST
6667

6768
private static final String INTEGRATIONTESTS_ORG = PROPBASE + "integrationTests.org.";
69+
6870
private static final Pattern orgPat = Pattern.compile("^" + Pattern.quote(INTEGRATIONTESTS_ORG) + "([^\\.]+)\\.mspid$");
6971

7072
private static final String INTEGRATIONTESTSTLS = PROPBASE + "integrationtests.tls";
@@ -129,6 +131,7 @@ private TestConfig() {
129131
defaultProperty(DEPLOYWAITTIME, "120000");
130132
defaultProperty(PROPOSALWAITTIME, "120000");
131133
defaultProperty(RUNIDEMIXMTTEST, "false");
134+
defaultProperty(RUNSERVICEDISCOVERYIT, "false");
132135

133136
//////
134137
defaultProperty(INTEGRATIONTESTS_ORG + "peerOrg1.mspid", "Org1MSP");
@@ -233,6 +236,17 @@ public boolean isFabricVersionBefore(String version) {
233236
return !isFabricVersionAtOrAfter(version);
234237
}
235238

239+
/**
240+
* Service discovery needs enteries in et/hosts to resolve names to run successfully.
241+
* By default turn off.
242+
*
243+
* @return true to run service discovery integration test.
244+
*/
245+
246+
public boolean runServiceDiscoveryIT() {
247+
return Objects.equals("true", sdkProperties.get(RUNSERVICEDISCOVERYIT));
248+
}
249+
236250
private static int[] parseVersion(String version) {
237251
if (null == version || version.isEmpty()) {
238252
throw new AssertionError("Version is bad :" + version);
@@ -461,7 +475,6 @@ public File getTestNetworkConfigFileYAML() {
461475
sourceText = sourceText.replaceAll("grpcs://localhost", "grpcs://" + LOCALHOST);
462476
sourceText = sourceText.replaceAll("grpc://localhost", "grpc://" + LOCALHOST);
463477

464-
465478
Files.write(Paths.get(temp.getAbsolutePath()), sourceText.getBytes(StandardCharsets.UTF_8),
466479
StandardOpenOption.CREATE_NEW, StandardOpenOption.TRUNCATE_EXISTING, StandardOpenOption.WRITE);
467480

src/test/java/org/hyperledger/fabric/sdkintegration/ServiceDiscoveryIT.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import org.hyperledger.fabric.sdk.exception.TransactionEventException;
4040
import org.hyperledger.fabric.sdk.security.CryptoSuite;
4141
import org.hyperledger.fabric.sdk.testutils.TestConfig;
42-
import org.junit.Ignore;
4342
import org.junit.Test;
4443

4544
import static java.lang.String.format;
@@ -58,11 +57,14 @@ public class ServiceDiscoveryIT {
5857
String CHAIN_CODE_NAME = "example_cc_go";
5958
TransactionRequest.Type CHAIN_CODE_LANG = TransactionRequest.Type.GO_LANG;
6059

61-
@Ignore //Hostnames reported by service discovery won't work unless you edit hostfile
6260
@Test
6361
public void setup() throws Exception {
6462
//Persistence is not part of SDK. Sample file store is for demonstration purposes only!
6563
// MUST be replaced with more robust application implementation (Database, LDAP)
64+
if (!testConfig.runServiceDiscoveryIT()) {
65+
out("\n\n\nNOT RUNNING: \"ServiceDiscoveryIT\" runServiceDiscoveryIT=%b.\n", testConfig.runServiceDiscoveryIT());
66+
return;
67+
}
6668
out("\n\n\nRUNNING: %s.\n", "ServiceDiscoveryIT");
6769

6870
SampleStore sampleStore = new SampleStore(sampleStoreFile);

0 commit comments

Comments
 (0)