[pg-maxconns] adding maxconns to postgres config #134
Conversation
Signed-off-by: David Echelberger <david.echelberger@kaleido.io>
dechdev
requested review from
awrichar,
nguyer and
peterbroadhurst
as code owners
| PostgreSQL: &CommonDBConfig{ | ||
| URL: getPostgresURL(member), | ||
| URL: getPostgresURL(member), | ||
| MaxConns: 50, |
There was a problem hiding this comment.
Shouldn't this take the value from the config, but with a default of 50 set?
There was a problem hiding this comment.
ah, ok - one sec ... maybe this code uses config different. Let me take a look around the change.
There was a problem hiding this comment.
oh - sorry. Ok, completely my bad. I assumed I was looking at firefly (not firefly-cli).
I think this code change should be in FireFly (not the CLI).
There was a problem hiding this comment.
See comment here: https://github.com/hyperledger/firefly/blob/4f4390336ee0b6c9f68b5ed2b79ffc3fbbf293d1/internal/database/sqlcommon/config.go#L44
... I think we've learned PostgreSQL should be in the group that sets a default
There was a problem hiding this comment.
Example of how SQLite does the default to 1, which you could copy to PSQL to set the default to 50:
https://github.com/hyperledger/firefly/blob/4f4390336ee0b6c9f68b5ed2b79ffc3fbbf293d1/internal/database/sqlite3/config.go#L27-L34
|
hyperledger/firefly#385 Made a PR in firefly for this. Closing this |
2 participants
Helps solve
ERROR SQL query failed: pq: sorry, too many clients alreadyerror seen in hyperledger/firefly#380