E2E Failure - TestE2EPrivate

[peterbroadhurst]

https://github.com/hyperledger/firefly/runs/5098942649?check_suite_focus=true

2022-02-07T19:47:31.8457440Z     restclient.go:72: <== 200
2022-02-07T19:47:31.8459865Z     e2e_test.go:87: Message 0: {Header:{ID:993f4494-ccf6-4926-a4d1-0c91362301f4 CID: Type:private TxType:batch_pin Identity:{Author:did:firefly:org/eac42049-9d65-42e5-a17d-23e84c35f7dc Key:0x976f242b16a552dd8103124075936cffff2bd7b3} Created:2022-02-07T19:47:29.990956566Z Namespace:default Group:32913ea99004a74754265c0449e1a6c684d9680e89f3cba12505298654e94b35 Topics:topicA Tag: DataHash:ac2828c23fba104fd587f7018fff3ce66d47f8c144845cd2bcdae72423a41e16} Hash:1e411d6b2aaaff9779184a6e9f7da2c9e0bcb7cc2852d90a0d989c28cb6c83d7 BatchID:d8597212-7b40-404c-baa1-040165fec384 State:confirmed Confirmed:2022-02-07T19:47:31.810332929Z Data:[0xc000268b58] Pins: Sequence:0}
2022-02-07T19:47:31.8467766Z     e2e_test.go:87: Message 1: {Header:{ID:325abed4-7266-4245-8320-02d3e9e62f8f CID: Type:private TxType:batch_pin Identity:{Author:did:firefly:org/eac42049-9d65-42e5-a17d-23e84c35f7dc Key:0x976f242b16a552dd8103124075936cffff2bd7b3} Created:2022-02-07T19:47:30.007865774Z Namespace:default Group:b288314a4a52933288ead0e4f19e7875e66beb67fd7bc548466e06769dff7f26 Topics:topicA Tag: DataHash:75977488b7c5c47216b1df628a514c7e7991a208f001ddbb34fe48094be09d14} Hash:7f1aabb4907400fa2cf7181c434e8e19c04f497e57b7b2562c2b046a13cb175b BatchID:89b4862c-97b1-47eb-bcb1-7330ea2d9f94 State:confirmed Confirmed:2022-02-07T19:47:31.811014439Z Data:[0xc000268ca8] Pins: Sequence:0}
2022-02-07T19:47:31.8468771Z     e2e_test.go:89: 
2022-02-07T19:47:31.8469107Z         	Error Trace:	e2e_test.go:89
2022-02-07T19:47:31.8469717Z         	            				onchain_offchain_test.go:236
2022-02-07T19:47:31.8470021Z         	Error:      	Not equal: 
2022-02-07T19:47:31.8470782Z         	            	expected: "32913ea99004a74754265c0449e1a6c684d9680e89f3cba12505298654e94b35"
2022-02-07T19:47:31.8471616Z         	            	actual  : "b288314a4a52933288ead0e4f19e7875e66beb67fd7bc548466e06769dff7f26"
2022-02-07T19:47:31.8471965Z         	            	
2022-02-07T19:47:31.8472279Z         	            	Diff:
2022-02-07T19:47:31.8477911Z         	            	--- Expected
2022-02-07T19:47:31.8478318Z         	            	+++ Actual
2022-02-07T19:47:31.8478798Z         	            	@@ -1 +1 @@
2022-02-07T19:47:31.8479578Z         	            	-32913ea99004a74754265c0449e1a6c684d9680e89f3cba12505298654e94b35
2022-02-07T19:47:31.8480334Z         	            	+b288314a4a52933288ead0e4f19e7875e66beb67fd7bc548466e06769dff7f26
2022-02-07T19:47:31.8480782Z         	Test:       	TestEthereumE2ESuite/TestE2EPrivate
2022-02-07T19:47:31.8481202Z         	Messages:   	All messages must be same group

[peterbroadhurst]

Another instance: https://github.com/hyperledger/firefly/runs/5101018496?check_suite_focus=true

[peterbroadhurst]

The root problem here, seems to be we have two groups:

2022-02-07T19:47:31.8044205Z Websocket 127.0.0.1:5001 receive: {"type":"change_notification","change":{"collection":"groups","type":"created","namespace":"default","hash":"32913ea99004a74754265c0449e1a6c684d9680e89f3cba12505298654e94b35"}}
2022-02-07T19:47:31.8044992Z Websocket 127.0.0.1:5001 receive: {"type":"change_notification","change":{"collection":"groups","type":"created","namespace":"default","hash":"b288314a4a52933288ead0e4f19e7875e66beb67fd7bc548466e06769dff7f26"}}

That shouldn't be possible per the intent of the test, so I need to investigate

[peterbroadhurst]

Ha - actually pretty simple:

firefly/test/e2e/restclient.go

Line 304 in 0c7b08b

Name: fmt.Sprintf("test_%d", time.Now().Unix()),

The test was implicitly relying on sending all the messages within the same second ⏲️ ⏩