Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Sep 22, 2022

Raised from #1025

  • Adds better logging
  • Ensures we do a DeliveryResponse in the case of a non-reply, non-fastack webhook subscription
  • Disabled fastack when reply is configured, as the reply would not be sent otherwise
  • (Re)instate the lost events section in the config docs
  • Correct the docs to reflect that if you want to retry on non-2xx error codes, you need to set events.webhooks.retry

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst marked this pull request as ready for review September 22, 2022 18:18
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst changed the title Enhanced logging for webhooks Fix acknowledgement for webhooks in non-reply, non-fastack cases Sep 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #1072 (65b24c4) into main (cd6a4d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 65b24c4 differs from pull request most recent head 96f3e76. Consider uploading reports for the commit 96f3e76 to get more accurate results

@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         307      307           
  Lines       20294    20315   +21     
=======================================
+ Hits        20292    20313   +21     
  Misses          2        2           
Impacted Files Coverage Δ
internal/events/webhooks/webhooks.go 100.00% <100.00%> (ø)
internal/namespace/manager.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Co-authored-by: Nicko Guyer <nguyer@users.noreply.github.com>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@nguyer nguyer merged commit a26e220 into hyperledger:main Sep 26, 2022
@nguyer nguyer deleted the wh-logging branch September 26, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants