Set firstEvent default using string #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
requested review from
awrichar,
nguyer and
shorsher
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1089 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 307 307
Lines 20331 20331
=======================================
Hits 20329 20329
Misses 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nguyer
approved these changes
Oct 14, 2022
Contributor
nguyer
left a comment
nguyer
left a comment
There was a problem hiding this comment.
Looks great. Thanks for sorting this one out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viper.GetStringdoes not return a value, if the default was set to a type that wraps string.So the fact we were setting the default for
firstEventascore.SubOptsFirstEventOldest, meant the default did not work.This is a significant bug, as it changes the default in v1.1 to listen from the current block (the EthConnect/FabConnect/EVMConnect default for an unset value), rather than the beginning of the blockchain (as we did in v1.0).