Skip to content

Conversation

@nguyer
Copy link
Contributor

@nguyer nguyer commented Oct 18, 2022

Signed-off-by: Nicko Guyer nicko.guyer@kaleido.io

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #1091 (2315972) into main (b31f9a6) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   99.99%   99.96%   -0.03%     
==========================================
  Files         307      307              
  Lines       20331    20331              
==========================================
- Hits        20329    20323       -6     
- Misses          2        6       +4     
- Partials        0        2       +2     
Impacted Files Coverage Δ
internal/events/webhooks/webhooks.go 97.23% <0.00%> (-2.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


## Additional info

- Config Reference: [HTTP Auth](../reference/config.html#httpauth)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a pointer to the plugin code interface here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as that is in firefly-common)

Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On suggestion @nguyer

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@nguyer nguyer merged commit 112e1dc into hyperledger:main Nov 16, 2022
@nguyer nguyer deleted the auth-tutorial branch November 16, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants