Create new guide for Fabric test-network #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
nguyer
requested review from
awrichar,
nickgaski,
peterbroadhurst and
shorsher
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 99.99% 99.98% -0.01%
==========================================
Files 307 307
Lines 20331 20331
==========================================
- Hits 20329 20327 -2
- Misses 2 3 +1
- Partials 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
jimthematrix
approved these changes
Nov 3, 2022
Contributor
jimthematrix
left a comment
jimthematrix
left a comment
There was a problem hiding this comment.
Approved with a small update request
| nav_order: 7 | ||
| --- | ||
|
|
||
| # Work with Fabric Test Network |
Contributor
There was a problem hiding this comment.
Suggested change
| # Work with Fabric Test Network | |
| # Work with Fabric-Samples Test Network |
Contributor
There was a problem hiding this comment.
...to make it more recognizable
docs/_i18n/en.yml
Outdated
| web3_gateway_features: Web3 Gateway Features | ||
| web3_gateway_features: Web3 Gateway Features | ||
| basic_auth: Enable Basic Auth | ||
| fabric_test_network: Fabric Test Network |
Contributor
There was a problem hiding this comment.
Suggested change
| fabric_test_network: Fabric Test Network | |
| fabric_test_network: Fabric-Samples Test Network |
Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
peterbroadhurst
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tutorial for using the FireFly CLI with the Fabric test-network from the fabric-samples repo. CLI changes in hyperledger/firefly-cli#225 are a prerequisite for this tutorial.