Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Jan 5, 2023

After fix:
image

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #1130 (36cfeaf) into main (f1b10e9) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   99.34%   99.61%   +0.26%     
==========================================
  Files         303      303              
  Lines       19695    19701       +6     
==========================================
+ Hits        19566    19625      +59     
+ Misses        120       75      -45     
+ Partials        9        1       -8     
Impacted Files Coverage Δ
internal/apiserver/server.go 99.07% <100.00%> (-0.93%) ⬇️
internal/namespace/manager.go 100.00% <100.00%> (ø)
internal/blockchain/ethereum/ethereum.go 100.00% <0.00%> (+0.33%) ⬆️
internal/events/aggregator_rewind.go 100.00% <0.00%> (+0.65%) ⬆️
internal/blockchain/fabric/fabric.go 100.00% <0.00%> (+0.78%) ⬆️
internal/events/aggregator.go 100.00% <0.00%> (+2.74%) ⬆️
internal/orchestrator/persistence_events.go 100.00% <0.00%> (+3.70%) ⬆️
internal/contracts/manager.go 100.00% <0.00%> (+4.16%) ⬆️
internal/definitions/handler_contracts.go 100.00% <0.00%> (+4.47%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@nguyer nguyer merged commit 42f5105 into main Jan 6, 2023
@nguyer nguyer deleted the or-nil branch January 6, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing an invalid namespace when connecting websocket causes a crash

4 participants