Add option to invoke the addressResolver on every call #1141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address resolver is a very useful plug point for FireFly with EVM based chains that have sophisticated signing infrastructures.
We have a requirement for the interface to be called on every API call that has a
keyinput on the Hyperledger FireFly API, regardless of whether the input string conforms to an0xaddress already, and regardless of how many times it is called.This PR introduces a single new config option
alwaysResolveto do this.I added a second commit on this PR, after doing quite a detailed review of every place we were calling the address
resolver. I found the terminology was still confusing (know we've had a few changes) and make a tweak.
I also made the following changes:
ethereumconnector it was using theNormalizeSigningKeyfunction, to just format an ethereum address. That is now fixedIdentity Manager, because this would have got int the way of the removal of the cache in the blockchain layer. Also, both Ethereum and Fabric already had caches for the expensive logic that wasn't just string formatting, so it seemed completely redundant.doDeliverythat was alwaysnil