public vs. permissioned page #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aznrayizzle
requested review from
awrichar,
nguyer,
nickgaski,
peterbroadhurst and
shorsher
as code owners
awrichar
approved these changes
Jan 17, 2023
Contributor
|
Looks like you need to add signoff for DCO. This looks fine to me, but might be worth a check with @peterbroadhurst to confirm if this is close enough to the current committed architecture. This doc looks like it was written while FFTM was still evolving, so could need some updating. |
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 305 305
Lines 19966 19966
=======================================
Hits 19964 19964
Misses 1 1
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: aznrayizzle <ray.chen@kaleido.io>
aznrayizzle
force-pushed
the
publicpermission
branch
from
dc7a1ca to
e8fb0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added back public vs. permissioned page